piecrust: optional owner in Session::migrate
#339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We specify that the caller is *heavily* encouraged to pass owners that are always the same size for every contract.
It is now optional to provide an `owner` to the `Session::migrate` call. If the owner is not specified, it will be taken from the previous contract at the slot being migrated. If the owner is not specified and the contract being replaced does not exist, the call will panic. Resolves #336
ureeves
force-pushed
the
optional-owner-336
branch
from
b059006
to
e6aaba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session::migrateis changed to allow for taking the owner of the previous contract, as opposed to it being mandatory to set a new owner.This entailed numerous API change, the gist of which being that the
owneris handled internally as aVec<u8>as opposed to a[u8; N]. This puts some responsibility on the user of the crate to think about what this means for when the contracts callownerorself_owner. It is likely wise to only set owner which are always the same size.Resolves #336