uplink: add impl PartialEq<[u8; 32]> for ContractId
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the cross crate considerations* of the Rust documentation, one should only implement `PartialEq` for local types, and not for foreign types. As for implementing it on references... `PartialEq` already takes both operands by reference, making these implementations useless in practice. * https://doc.rust-lang.org/std/cmp/trait.PartialEq.html#cross-crate-considerations Resolves: #375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the cross crate considerations of the Rust documentation, one should only implement
PartialEqfor local types, and not for foreign types.As for implementing it on references...
PartialEqalready takes both operands by reference, making these implementations useless in practice.Resolves: #375