Remove the concept of an "uninitialized" ContractId
#377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The integer signals whether there is actually a caller or not. It will be 1 if there is a caller, 0 if no caller, and the contract is the first in the call chain. This allows for contracts to more easily handle the situation in which they're the first to be called, a situation which happens often downstream in e.g. queries.
HDauven
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the concept of a
ContractIdbeing "uninitialized" and all related functionality, and in its place put in an improved ABI, using an integer to signal whether there is a caller or not. These two concepts are semantically equivalent, with the exception that in the former the contract at "zero"ContractIdis not a possible caller - instead being considered "uninitialized".As a consequence, we can return
Option<ContractId>frompiecrust_uplink::caller, which is a much clearer and more ergonomic API.