Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed state representation to delta representation to improve commit performance #387

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

miloszm
Copy link
Contributor

@miloszm miloszm commented Sep 27, 2024

Changed the state persistence representation into a delta-based representation in order to improve the commit performance.

Commits now store only what is changed, with the rest of content taken either from the base commit or from the current main commit.

Addresses issue #342

Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Very nice and focused. I would prefer to not have so many expects around, but that's just consequence of state corruption being possible.

piecrust/src/store/session.rs Show resolved Hide resolved
piecrust/tests/root.rs Outdated Show resolved Hide resolved
piecrust/src/store/session.rs Outdated Show resolved Hide resolved
piecrust/src/store.rs Show resolved Hide resolved
piecrust/src/store.rs Show resolved Hide resolved
piecrust/src/store.rs Show resolved Hide resolved
@ureeves
Copy link
Member

ureeves commented Sep 27, 2024

I like it. Very nice and focused. I would prefer to not have so many expects around, but that's just consequence of state corruption being possible.

Also, please make sure to update the commits to be prefixed with piecrust:

@miloszm miloszm force-pushed the issue-342-delta-representation branch from 77de6ab to a252105 Compare September 27, 2024 12:49
@miloszm miloszm force-pushed the issue-342-delta-representation branch from a252105 to a784db7 Compare September 27, 2024 12:50
@miloszm miloszm merged commit 421a0a3 into main Sep 27, 2024
6 checks passed
@miloszm miloszm deleted the issue-342-delta-representation branch September 27, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants