consensus: request ValidationResult in Emergency Mode #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fed-franz
force-pushed
the
ratifi-result
branch
2 times, most recently
from
955c87e
to
5d0c640
Compare
fed-franz
changed the title
fed-franz
force-pushed
the
ratifi-result
branch
4 times, most recently
from
b2235de
to
de12730
Compare
Change the method signature to take Header+Result instead of Ratification
- moves on_emergency_mode logic into handle_past_msg - collect Candidate messages and then vote - process both ValidationResults (produced or received via ValidationQuorum messages) when returning from process_past_msg
node: clean fsm code
Fix ValidationQuorum
autholykos
requested changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2483
[First part implemented in #2447]
Add the ValidationQuorum message, which contains a ValidationResult
Add InvType::ValidationResult and InvParam::Iteration
Request ValidationResult via GetResource if Validation times-out in Emergency Mode
Handle GetResource requesting a ValidationResult
Refactor past-message handling
Refactor candidate request by replacing InvParam::IterationAndHash with InvParam::Iteration
Rename Candidate trait to ConsensusStorage
Add ValidationResults functions to ConsensusStorage trait
Store ValidationResults in Validation handler, both from reaching quorum with Validation vote and from receiving ValidationQuorum msg from a peer