Flav/input bar uses file api #5997
Conversation
| if (url && url.startsWith(FileResource.baseFileUrl(owner))) { | ||
| // Use the provided URL if it is an internal file path. | ||
| sourceUrl = url; | ||
| } else if (isSupportedUploadableContentFragmentType(contentType)) { | ||
| // Deprecated, for supported content types, create a file path and use its download URL. | ||
| sourceUrl = fileAttachmentLocation({ | ||
| workspaceId: owner.sId, | ||
| conversationId: conversation.sId, | ||
| messageId, | ||
| contentFormat: "raw", | ||
| }).downloadUrl; | ||
| } else { | ||
| // Otherwise, use the provided URL (e.g., a Slack thread). | ||
| sourceUrl = url; | ||
| } |
There was a problem hiding this comment.
Not sure what's different than previously?
Basically if we not in isSupportedUploadableContentFragmentType(contentType) we set sourceUrl = url, right?
There was a problem hiding this comment.
The difference is that know the client passes an url that points toward our own infrastructure, if this is the case, we use it as the url, otherwise we fallback to the previous logic.
There was a problem hiding this comment.
Nitpicking here but unless I'm missing something this is equivalent to:
if (isSupportedUploadableContentFragmentType(contentType)) {
// Deprecated, for supported content types, create a file path and use its download URL.
sourceUrl = fileAttachmentLocation({
workspaceId: owner.sId,
conversationId: conversation.sId,
messageId,
contentFormat: "raw",
}).downloadUrl;
} else {
sourceUrl = url;
}
front/lib/resources/file_resource.ts
Outdated
| @@ -83,6 +88,10 @@ export class FileResource extends BaseResource<FileModel> { | |||
| }); | |||
| } | |||
|
|
|||
| static baseFileUrl(owner: LightWorkspaceType): string { | |||
There was a problem hiding this comment.
Based on my previous comment this might be deadcode
There was a problem hiding this comment.
This is temporary, we will rework this API to accept either a fileId or a content. This is an intermediary state.
| onClose={() => { | ||
| fileUploaderService.removeFile(blob.id); | ||
| }} | ||
| isLoading={blob.isUploading} |
* Use file upload API in the input bar * Stop uploading raw content fragment * ✨ * 👕 * 📝 * ✨ * ✂️ * ✂️ * ✂️ * ✂️ * :sparkles * ✨
* Use file upload API in the input bar * Stop uploading raw content fragment * ✨ * 👕 * 📝 * ✨ * ✂️ * ✂️ * ✂️ * ✂️ * :sparkles * ✨
Description
In #5977, we introduced a file API to manage all file-related tasks. This PR begins using that endpoint.
The key changes include:
Demo:
Risk
If we rollback, all conversations created during this time, won't support new messages.
Deploy Plan