refactor: Use less brittle TLS settings construction #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change uses a record update on the default TLSSettings, to prevent changes in available settings causing build failures. For example, crypton-connection added a 'settingClientSupported' field to 'TLSSettings'.
dustin
reviewed
Jun 27, 2024
| @@ -157,7 +158,10 @@ mqttConfig = MQTTConfig{_hostname="", _port=1883, _connID="", | |||
| _msgCB=NoCallback, | |||
| _protocol=Protocol311, _connProps=mempty, | |||
| _connectTimeout=180000000, | |||
| _tlsSettings=TLSSettingsSimple False False False, | |||
| _tlsSettings=def | |||
There was a problem hiding this comment.
def is defined as TLSSettingsSimple False False False so I think just using def here without specifying all the fields is the right thing here.
|
I've included this along with a package.yaml change and the default dfe. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses a record update on the default TLSSettings, to prevent
changes in available settings causing build failures.
For example, crypton-connection added a 'settingClientSupported' field
to 'TLSSettings'.