This repository has been archived by the owner on Nov 7, 2023. It is now read-only.
Update garena checks for the new patch #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, so this is the new path in garena? Brilliant, thanks! I'm unsure why the Travis builds failed, I've triggered a rerun. However it looks like you'll need to update the path manager tests with the new exe before it can be merged. |
|
@dustinblackman weird bcs I just forked it and pushes the changes and it seems to be working, maybe I overlook some things lol, I will take a look again and hopefully fix it 👍 |
|
I'd assume it's working, but it's just the tests need to be updated along with it. :) https://github.com/dustinblackman/Championify/blob/master/tests/path_manager.js#L83-L94 |
|
@dustinblackman ah I see now, my bad |
hollowsxd
added a commit
to hollowsxd/Championify
that referenced
this pull request
Nov 22, 2017
Fix the failed test for dustinblackman#367
hollowsxd
added a commit
to hollowsxd/Championify
that referenced
this pull request
Nov 22, 2017
Fix the failed test for dustinblackman#367
update efbb993 so that it works on root folder instead of the game folder
|
I changed it again so that the root folder get selected instead of the Game folder, also updated the test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #291