Fix scm specified surface flux bug #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in_20211215 Update gsl/develop from main 2021/12/15
Updates to MYNN-EDMF, part I - goes with other PR for fv3atm
Overview of changes:
This commit should be considered step one of the "universalization" process to generalize module_bl_mynn.F90 both for all dycores. Much of this is strictly reformatting or repositioning the driver to the top of the module - a request from collaborators, but some of it involve removing ifdefs, and the handling of the model constants. More commits to complete this work will follow. Despite the huge number of lines changed from this work alone, there is no change in behavior/performance.
fixed some old crash cases (improved numerical stability)
conservation work - removes all negative qv printouts
A bug fix for the interpolation of the mass-flux clouds from interface levels to mid-levels which cause excessive LWP in shallow-cumulus fields
Removes a few unused variables/arrays
Fixes for the smoke/chemical mixing (works but still not in final state - another commit will follow)
Some tuning work to improve the excessive cloud bias in polar regions.
Some tuning of the mass-flux component to improve the tropics.
General clean up of code and updates to many comments.
… into snow and ice This modification adds: 1. A new cloud fraction (Chaboureau and Bechtold 2005) for the GF convection scheme 2. The capability to separate frozen subgrid clouds into both snow and ice (no longer just ice).
Merge NCAR main into gsl/develop
…no shallow scheme
Remove GF Consistency Check & Add SDFs - V2
Remove Dom, add new code manager Christina and various developers.
Updates to the MYNN-EDMF
…into gsl/develop_physics_mods_from_RRFS_dev
…rom_RRFS_dev GWD, LSM and MYNN physics updates from RRFS_dev branch
…o namelist options
gsl/develop RRFS-Smoke
…n sgscloud_radpre
…o-community merge gsl institutional fork
dustinswales
pushed a commit
that referenced
this pull request
Dec 6, 2022
Update to parametric values in prognostic convection for GFSv17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dustinswales This is a one-file fix for running the SCM with specified surface fluxes with the DEPHY format. This fixes a bug discovered by Xia Sun and needs to go in for the release. I'd like to combine it with your PR into main.
My changes should be one file (scm_sfc_flux_spec.F90), although when I tried this pull request into your branch, it looks like the branch started out as old, so there are many more commits/files to bring the branch up-to-date with main.