Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session #1

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

session #1

wants to merge 26 commits into from

Conversation

dusty
Copy link
Owner

@dusty dusty commented Aug 10, 2023

Implemented auto sessions, but was having problems with req.getSetCookie() not existing on node response.
It should work since we are running node 20. Could remix be modifying the req object?

Removed remix-hono and set this up manually to see if that was causing problems with set-cookie headers.
That wasn't the problem.

Patched @hono/node-server to allow us to set-cookie. It might be ok if we are only serving one cookie.

@dusty
Copy link
Owner Author

dusty commented Aug 21, 2023

Tracking this issue to see if the fix might allow us to not patch hono. remix-run/remix#7067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant