lib/deploy: skip fallocate call when requested size is 0

If the requested size is 0 then of course we have enough room 🙂 This avoids the fallocate call returning an EINVAL. Closes: ostreedev#2869
dustymabe · Jun 1, 2023 · 68d1d9a · 68d1d9a
1 parent 5eacc96
commit 68d1d9a
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/libostree/ostree-sysroot-deploy.c b/src/libostree/ostree-sysroot-deploy.c
@@ -2446,6 +2446,14 @@ get_kernel_layout_size (OstreeSysroot *self, OstreeDeployment *deployment, guint
 static gboolean
 dfd_fallocate_check (int dfd, __off_t len, gboolean *out_passed, GError **error)
 {
+  /* If the requested size is 0 then return early. Passing a 0 len to
+   * fallocate results in EINVAL */
+  if (len == 0)
+    {
+      *out_passed = TRUE;
+      return TRUE;
+    }
+
   g_auto (GLnxTmpfile) tmpf = {
     0,
   };