Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit to address GH-ISSUE #1 #117

Conversation

codylane
Copy link

@codylane codylane commented Jul 29, 2020

As promised here is an implementation that uses pure STDLIB ruby instead of shelling out to whoami.

Also, I took the liberty to add 100% test coverage to the method in question.

  • - Stubbed out an initial commit of integration tests using Vagrant. I'll add serverspec tests to it in the next few days.

@codylane
Copy link
Author

Ok, I believe I've addressed the open issues for this PR now. Please let me know if you have questions or concerns.

@codylane codylane force-pushed the feature/investigate-using-a-mechanism-other-than-whoami-to-determine-username-#1 branch 6 times, most recently from bf89ef0 to c08b8b6 Compare July 31, 2020 18:02
@codylane codylane force-pushed the feature/investigate-using-a-mechanism-other-than-whoami-to-determine-username-#1 branch from c08b8b6 to 82c5cdb Compare August 9, 2020 15:56
@dustymabe
Copy link
Owner

Wow @codylane - that's a lot of awesome work. Sorry I'm only looking at it now.

For this particular issue can you remove all the extra stuff to another PR and just focus on fixing #1?

@codylane
Copy link
Author

codylane commented Sep 4, 2020

Wow @codylane - that's a lot of awesome work. Sorry I'm only looking at it now.

For this particular issue can you remove all the extra stuff to another PR and just focus on fixing #1?

You are very welcome, I'm excited and committed to help the open source community as best as I can. If this PR is approved I promise to be a maintainer for anything I help create.

No problem, I'd be happy to just address #1. Not sure I can remove the commits so I may need to close this one and re-open a new PR.

@dustymabe
Copy link
Owner

No problem, I'd be happy to just address #1. Not sure I can remove the commits so I may need to close this one and re-open a new PR.

You can easily remove the commits with an interactive rebase. It's the best thing since sliced bread :)

@codylane codylane force-pushed the feature/investigate-using-a-mechanism-other-than-whoami-to-determine-username-#1 branch from 82c5cdb to a1455b1 Compare September 6, 2020 16:46
@codylane
Copy link
Author

codylane commented Sep 6, 2020

I won't lie, I avoid doing interactive rebase as not only are they are to follow but they are hard to do right without additional problems and or messing up your git history or reflog.

Instead, I use the reflog to tell me which commits I want and then I re-write the history in a separate temporary working directory. It doesn't make what I do right, it just easier for me to understand and I've had much better luck than trying to pick commits or squash the history. Just my 3$.

I've removed the CI/CD stuff as you recommended and updated this commit to only reflect stuff needed to get GH #1 to pass. I'm still not sure this will be to your liking but it's my final attempt.

@codylane
Copy link
Author

Closing the request as it has been almost 60+ days without traction or guidance of how to proceed. I've lot all motivation for trying to help. I wish you the best. Take care.

@codylane codylane closed this Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants