Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gen keyword #41

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add gen keyword #41

merged 1 commit into from
Mar 7, 2024

Conversation

mohe2015
Copy link
Contributor

@mohe2015 mohe2015 commented Dec 21, 2023

As this is an edition 2024 keyword I don't know whether we want to do this. Because this will then also incorrectly highlight e.g. variable identifiers named gen in edition 2021

@Wilfred
Copy link
Collaborator

Wilfred commented Mar 7, 2024

Thanks for the PR!

Based on rust-lang/rfcs#3513, I see it's reached final comment period with disposition to merge, so this seems reasonable to merge. I imagine that identifiers named gen are rare, and I see we're already highlighting edition specific keywords (e.g. dyn) and weak keywords (e.g. union), based on Keywords in the Rust Reference.

@Wilfred Wilfred merged commit cf3c686 into dustypomerleau:main Mar 7, 2024
@mohe2015 mohe2015 deleted the gen branch March 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants