Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm scripts to pack an extension #35

Merged
merged 14 commits into from
Mar 30, 2023
Merged

npm scripts to pack an extension #35

merged 14 commits into from
Mar 30, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 1, 2023

I wanted to automate build process even more so that it generates a zip file which contains files under build directory after build success:

  • Added pack.js to generate a zip file
    where a name of a generated zip file would be <project directory name>-v<version>.zip
    where <version> is defined in manifest.json
  • Modified index.js:
    • To copy pack.js from template to actual project
    • To add npm script pack and repack
    • To add adm-zip as a dev dependency (pack.js uses it)

@dutiyesh
Copy link
Owner

dutiyesh commented Jan 8, 2023

Hey @internalstability, this is a good feature. Thank you!
I will review the pull request.

@ghost ghost changed the title Generate a zip file automatically after build success npm scripts to generate a zip file Jan 8, 2023
@ghost ghost changed the title npm scripts to generate a zip file npm scripts to pack an extension Jan 8, 2023
@sayeed205
Copy link

Any news on this?

templates/shared/pack.js Outdated Show resolved Hide resolved
templates/shared/pack.js Outdated Show resolved Hide resolved
templates/shared/pack.js Outdated Show resolved Hide resolved
index.js Show resolved Hide resolved
@dutiyesh
Copy link
Owner

Hey @internalstability my apologies, it took some time for me to review the pull request but let me know if you need any more clarity in above review comments.

@somidad
Copy link
Contributor

somidad commented Mar 28, 2023

Okay, will let you know when its done
(Sorry for confusion, I switched my account)

@somidad
Copy link
Contributor

somidad commented Mar 28, 2023

Please review execpt try-catch

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
templates/shared/pack.js Outdated Show resolved Hide resolved
templates/shared/pack.js Outdated Show resolved Hide resolved
@dutiyesh
Copy link
Owner

@gsongsong Thank you for adding this feature 🎉.

@dutiyesh dutiyesh merged commit 3768aec into dutiyesh:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants