Ensure that the semaphore keeps working when app after lpop of available key #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
You can kill the app in
def lock
just after the lpop of theavailable_key
When that happens the semaphore is gone forever. To fix it you have to
manually delete the exists key.
Expirations also don't help as for some reason the exists key get -1 as a ttl
Solution
The fix is to recreate the keys in redis if there isn't an AVAILABLE or GRABBED key
Related
https://stackoverflow.com/questions/60269868/redis-semaphore-locks-cant-be-released/
ps. I have never used the gem