Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the "Never suspend tabs that contain unsaved form inputs" feature #7

Open
wants to merge 1 commit into
base: firefox
Choose a base branch
from

Conversation

RJVB
Copy link

@RJVB RJVB commented Nov 13, 2024

There were several issues with this feature:
* the `event` variable isn't defined
* Firefox had unclear support for the `keyCode` property, which also
  has been deprecated for some time now.
* The key range seemed to consider only characters from '0' to 'Z',
  excluding lower case common text for instance.

With this patch the feature works, as shown by the screenshot:
screenshot5

@RJVB
Copy link
Author

RJVB commented Nov 13, 2024

@dvalter: It would be really nice if you could integrate this change quickly, as I can only run a Firefox version on my main machine that doesn't except unsigned extensions (and I'd rather not deal with changing the extension ID given how large my session is)!

@RJVB RJVB force-pushed the firefox-rjvb-keyevents branch from f7f711f to ac7e4d2 Compare November 13, 2024 17:20
There were several issues with this feature:
* the `event` variable isn't defined
* Firefox had unclear support for the `keyCode` property, which also
  has been deprecated for some time now.
* The key range seemed to consider only characters from '0' to 'Z',
  excluding lower case common text for instance.
@RJVB RJVB force-pushed the firefox-rjvb-keyevents branch from ac7e4d2 to ea4d755 Compare November 13, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant