Merge pull request rubocop#13659 from viralpraxis/fix-style-missing-e…

…lse-cop-error-on-configured-empty-else-cop-multiple-elsifs

Fix `Style/MissingElse` cop error if `Style/EmptyElse`'s style is not `both` and if expression contains `elsif`

changelog/fix_style_missing_else_cop_error_on_configured_empty_else_cop_multiple_elsifs.md

@@ -0,0 +1 @@
+* [#13659](https://github.com/rubocop/rubocop/pull/13659): Fix `Style/MissingElse` cop error if `Style/EmptyElse`'s `EnforcedStyle` is not `both` and `if` expression contains multiple `elsif`. ([@viralpraxis][])

lib/rubocop/cop/style/missing_else.rb

@@ -144,7 +144,7 @@ def message_template
         end
 
         def autocorrect(corrector, node)
-          node = node.parent unless node.loc.end
+          node = node.ancestors.find { |ancestor| ancestor.loc.end } unless node.loc.end
 
           case empty_else_style
           when :empty

spec/rubocop/cop/style/missing_else_spec.rb

@@ -275,6 +275,17 @@
             if cond_1; 1; elsif cond_2; 3; else; nil; end
           RUBY
         end
+
+        it 'registers an offense with multiple `elsif` clauses' do
+          expect_offense(<<~RUBY)
+            if cond_1; 1; elsif cond_2; 2; elsif cond_3; 3; end
+                                           ^^^^^^^^^^^^^^^ `if` condition requires an `else`-clause with `nil` in it.
+          RUBY
+
+          expect_correction(<<~RUBY)
+            if cond_1; 1; elsif cond_2; 2; elsif cond_3; 3; else; nil; end
+          RUBY
+        end
       end
     end
 
@@ -404,6 +415,17 @@
             if cond_1; 1; elsif cond_2; 3; else; end
           RUBY
         end
+
+        it 'registers an offense with multiple `elsif` clauses' do
+          expect_offense(<<~RUBY)
+            if cond_1; 1; elsif cond_2; 2; elsif cond_3; 3; end
+                                           ^^^^^^^^^^^^^^^ `if` condition requires an empty `else`-clause.
+          RUBY
+
+          expect_correction(<<~RUBY)
+            if cond_1; 1; elsif cond_2; 2; elsif cond_3; 3; else; end
+          RUBY
+        end
       end
     end
 
@@ -533,6 +555,17 @@
             if cond_1; 1; elsif cond_2; 3; else; end
           RUBY
         end
+
+        it 'registers an offense with multiple `elsif` clauses' do
+          expect_offense(<<~RUBY)
+            if cond_1; 1; elsif cond_2; 2; elsif cond_3; 3; end
+                                           ^^^^^^^^^^^^^^^ `if` condition requires an empty `else`-clause.
+          RUBY
+
+          expect_correction(<<~RUBY)
+            if cond_1; 1; elsif cond_2; 2; elsif cond_3; 3; else; end
+          RUBY
+        end
       end
     end