Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeScript Error Preventing Build #5

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

radamson
Copy link
Contributor

When running in Docker or locally the following error occurs:

src/services/converter.service.ts:35:11 - error TS2571: Object is of type 'unknown'.

35       if (e.message.includes('ENOENT: Failed to lookup')) {
             ~

Found 1 error.

This PR adds a type assertion to fix the TypeScript error so that the build can complete.

References:

Copy link

@mickohanlon23 mickohanlon23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully runs in development mode and in Docker.

Copy link
Contributor

@nkarip nkarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I can simulate the ERR_UNSUPPORTED response and get the correct 422 status.

@radamson radamson merged commit f553843 into master Sep 28, 2021
@radamson radamson deleted the fix-typescript-error branch September 28, 2021 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants