Dvci 265 icon splash #53
Conversation
There was a problem hiding this comment.
Looks good on android, but I am having trouble building with iOS. I am getting the following error:
The following build commands failed:
CompileAssetCatalog /Users/smcdougall/Library/Developer/Xcode/DerivedData/SMART_Health_Card_Verifier-butwbgdonuwimeesisigtlithivu/Build/Intermediates.noindex/ArchiveIntermediates/SMART\ Health\ Card\ Verifier/InstallationBuildProductsLocation/Applications/SMART\ Health\ Card\ Verifier.app /Users/smcdougall/vci/shc-web-verifier/platforms/ios/SMART\ Health\ Card\ Verifier/Images.xcassets (in target 'SMART Health Card Verifier' from project 'SMART Health Card Verifier')
(1 failure)
xcodebuild: Command failed with exit code 65
Any ideas on how to get the Cordova build to succeed for iOS? I think it's due to the splash image but could not come up with any fixes.
|
Turns out ios does not allow single-icon configuration, see apache/cordova-docs#1145. I changed to use an Ionic utility to generate the required icon files and update the config.xml. See README for instructions. Tested on ios simulator. |
There was a problem hiding this comment.
Cordova is able to build for iOS now! I tested it both on device and on simulator. I did notice that the icon shows up now but its more enlarged on iOS than on android, so it gets cut off a little. Also, on android I am able to see the "Loading..." paragraph on the splash page, but that does not appear on iOS. Not sure if these observations should be addressed in this PR - let me know your thoughts.
|
I think the icon looking funny is ok, since we're not releasing to the app store. There is a separate ticket for designing a real icon if we want to in the future. The underlying code/config would not change. |
Add default app icon, disable splash screen, fix suspense fallback