Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPD] French translation #25

Merged
merged 7 commits into from
Jan 5, 2021
Merged

Conversation

Gedo789
Copy link
Contributor

@Gedo789 Gedo789 commented Jan 2, 2021

Happy New Year everyone!

Copy link
Contributor Author

@Gedo789 Gedo789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tSet["tool."..sTool..".workmode.1" ] = "General spawn/snap pieces" should become tSet["tool."..sTool..".workmode.1" ] = "(Default choice) spawn/snap pieces"
Up to you.

@dvdvideo1234
Copy link
Owner

dvdvideo1234 commented Jan 4, 2021

Hello,

First of all and most important. Happy new year ;)

No. because the tool remembers the last value of the convar and updates the drop-down menu according to its value
on its first run here, because the panel modification is directly linked to it. Please leave it how it is, as it does not have such default value in the way it gets selected/updated:

local pComboToolMode = CPanel:ComboBox(asmlib.GetPhrase("tool."..gsToolNameL..".workmode_con"), sName)

@dvdvideo1234
Copy link
Owner

dvdvideo1234 commented Jan 4, 2021

I just saw https://github.com/Gedo789/TrackAssemblyTool/pull/7

So let me explain... Most of these hashes are for the tool convar tweak control menu. They update various convars with their values. Consider this tSet["tool."..sTool..".curvefact" ] . This is in fact the tool tip of the panel when it is hovered with the mouse. These that have _con are evaluated to control for example tSet["tool."..sTool..".curvefact_con" ] just tells what the checkbox/slider/button should be labeled as. For example you have a button named test and when you hover on it must display Click to test me! ( and you click the button to test something ), so the _con value must be equal to test in this case ;) and the one without _con to Click to test me!

Reverted change to work mode 1.
@Gedo789
Copy link
Contributor Author

Gedo789 commented Jan 4, 2021

Done.

@dvdvideo1234 dvdvideo1234 merged commit 8629b4d into dvdvideo1234:master Jan 5, 2021
@dvdvideo1234
Copy link
Owner

Merci beaucoup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants