upgrade webpack from 1 to 2 #1189

rauleite · 2017-03-09T22:28:27Z

Migration completed, as follows:
https://webpack.js.org/guides/migrating/

why?
https://medium.com/webpack/webpack-2-and-beyond-40520af9067f

codecov-io · 2017-03-09T22:49:53Z

Codecov Report

Merging #1189 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files          12       12           
  Lines          66       66           
=======================================
  Hits           48       48           
  Misses         18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd16e16...dab9d97. Read the comment docs.

nathan-charrois · 2017-03-16T23:39:29Z

Any thoughts on passing sassLoader options directly instead of through LoaderOptionsPlugin? The implementation in this PR will break style paths when using @import './style' in components/routes unless context is provided.

ie.

{
  test: /\.scss$/,
  use: [
    {
      loader: 'sass-loader',
      options: {
        sourceMap: true,
        includePaths: [
          project.paths.client('styles')
        ]
      }
    }
  ]
}

More info: webpack-contrib/sass-loader#285 (comment)

rauleite · 2017-03-17T00:29:57Z

Hi Nathan, I'm sorry I can not help you right now because of lack of time =/

I hope someone helps you!

nathan-charrois · 2017-03-17T00:40:39Z

No worries man, and thanks. I can confirm this is working, I'll make a separate PR if it doesn't make it into the webpack upgrade.

rauleite · 2017-03-17T12:20:19Z

Very good! Good luck with this.

Slumber86 · 2017-03-23T17:24:18Z

I think you forgot an option for sass-loader

options : {
        sourceMap : true,
        includePaths: [...project.paths.client('styles'), './node_modules',]
      }

Slumber86 · 2017-03-23T17:44:22Z

Also you missed to migrate from babel to webpack the ES2015 module resolution:
in project.config.js

  compiler_babel : {
    cacheDirectory : true,
    plugins        : ['transform-runtime'],
    presets        : [["es2015", { "modules": false }], 'react', 'stage-0']
  },

collinwu · 2017-03-28T21:08:54Z

Any status on this? I have an upcoming project and I'd love to leverage this repo, but with webpack 2 :)

0-vortex · 2017-03-29T02:02:24Z

Dedupe plugin is useless and prefix doesn't work for font loaders. I leveraged that with name: 'fonts/[name].[ext]', cheers !

piu130 · 2017-03-29T06:45:06Z

Why don't we switch to neutrino? It's much easier and you don't have to debug build stuff anymore. See #1177.

pluswhite · 2017-04-20T03:23:11Z

It's works follow your codes, thx ;) @rauleite

whawker · 2017-04-28T08:53:46Z

config/karma.config.js

@@ -23,6 +23,7 @@ const karmaConfig = {
  browsers : ['PhantomJS'],
  webpack  : {
    devtool : 'cheap-module-source-map',
+    entry: './tests/test-bundler.js',


Should this be ./${project.dir_test}/test-bundler.js like on line 11 of this file

prestonbernstein · 2017-05-01T14:20:24Z

What's the status on this?

whawker · 2017-05-02T13:15:09Z

config/webpack.config.js

  webpackConfig.plugins.push(
    new webpack.HotModuleReplacementPlugin(),
-    new webpack.NoErrorsPlugin()
+    new webpack.NoEmitOnErrorsPlugin()
  )
 } else if (__PROD__) {
  debug('Enabling plugins for production (OccurenceOrder, Dedupe & UglifyJS).')
  webpackConfig.plugins.push(
    new webpack.optimize.OccurrenceOrderPlugin(),
    new webpack.optimize.DedupePlugin(),


Probably should remove the DedupePlugin? https://webpack.js.org/guides/migrating/#dedupeplugin-has-been-removed

matgessel · 2017-05-09T01:44:12Z

config/webpack.config.js

  })
-]
+)

 // File loaders
 /* eslint-disable */


I think we can eliminate the eslint-disable; it was there for the compact loader definitions.

matgessel · 2017-05-09T01:47:49Z

config/webpack.config.js

  })
-]
+)

 // File loaders
 /* eslint-disable */


Less boilerplate:

const FONT_EXTS = new Map([ ['woff', 'application/font-woff'], ['woff2', 'application/font-woff2'], ['otf', 'font/opentype'], ['ttf', 'application/octet-stream'], ['eot', 'application/vnd.ms-fontobject'], ['svg', 'image/svg+xml'], ]); for (let [extension, mimeType] of FONT_EXTS) { webpackConfig.module.rules.push({ test : new RegExp(`\\.${extension}(\\?.*)?$`), loader : 'url-loader', options : { name : 'fonts/[name].[ext]', limit : '10000', mimetype : mimeType, }, }); }; webpackConfig.module.rules.push( { test : /\.(png|jpg|gif)$/, loader : 'url-loader', options : { limit : '8192', }, }, );

Note addition of .gif
Also note that file-loader does not support limit, so I assumed url-loader was intended.
I haven't tested this code yet.

matgessel · 2017-05-09T01:48:32Z

config/webpack.config.js

  query   : project.compiler_babel
 }, {
  test   : /\.json$/,
-  loader : 'json'
+  loader : 'json-loader'
 }]


Can eliminate this. JSON loader is built-in in Webpack 2.

freele · 2017-05-16T12:51:43Z

config/webpack.config.js

-    delete loader.loaders
+  webpackConfig.module.rules.filter(rule =>
+    rule.loader && /css/.test(rule.loader)
+  ).forEach(loader => {


isn't it a misspell here?

... ).forEach(rule => { ...

dvdzkwsk · 2017-05-16T14:37:58Z

Moving to #1243.

Thanks for your work, I'll try to cherry-pick some of your fixes over. I have private project that just recently bumped webpack to 2.0, so I'm currently porting all of those changes over here.

rauleite force-pushed the master branch from 92716e2 to af919ee Compare March 9, 2017 23:23

update to node7 in yml to gyp

49526b1

rauleite force-pushed the master branch from af919ee to 49526b1 Compare March 9, 2017 23:24

rauleite added 15 commits March 10, 2017 12:48

up webpack2

455d4a6

yarn.lock

726f581

node version in travis

e394cff

yml without cache

36388bd

yml without cache

4c1d76d

yml gcc

82662ae

yml build essential

dd3fb63

yml build node version

6e35f56

yarn.lock regenerated

cb73f20

module dev removed

8627411

revert .travis.yml to original

fcb8279

revert spread plugin

0c700fa

cache .yml

0a99ada

cache .yml

714a162

cache .yml

dab9d97

dvdzkwsk mentioned this pull request Apr 5, 2017

Upgrade WebPack to 2.x #1211

Closed

whawker reviewed Apr 28, 2017

View reviewed changes

whawker reviewed May 2, 2017

View reviewed changes

matgessel reviewed May 9, 2017

View reviewed changes

freele reviewed May 16, 2017

View reviewed changes

dvdzkwsk closed this May 16, 2017

dvdzkwsk mentioned this pull request May 16, 2017

refactor(build): upgrade to webpack 2 #1243

Merged

15 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade webpack from 1 to 2 #1189

upgrade webpack from 1 to 2 #1189

rauleite commented Mar 9, 2017 •

edited

Loading

codecov-io commented Mar 9, 2017 •

edited

Loading

nathan-charrois commented Mar 16, 2017 •

edited

Loading

rauleite commented Mar 17, 2017

nathan-charrois commented Mar 17, 2017

rauleite commented Mar 17, 2017

Slumber86 commented Mar 23, 2017 •

edited

Loading

Slumber86 commented Mar 23, 2017

collinwu commented Mar 28, 2017

0-vortex commented Mar 29, 2017

piu130 commented Mar 29, 2017

pluswhite commented Apr 20, 2017

whawker Apr 28, 2017

prestonbernstein commented May 1, 2017

whawker May 2, 2017

matgessel May 9, 2017 •

edited

Loading

matgessel May 9, 2017 •

edited

Loading

matgessel May 9, 2017

freele May 16, 2017

dvdzkwsk commented May 16, 2017

upgrade webpack from 1 to 2 #1189

upgrade webpack from 1 to 2 #1189

Conversation

rauleite commented Mar 9, 2017 • edited Loading

codecov-io commented Mar 9, 2017 • edited Loading

Codecov Report

nathan-charrois commented Mar 16, 2017 • edited Loading

rauleite commented Mar 17, 2017

nathan-charrois commented Mar 17, 2017

rauleite commented Mar 17, 2017

Slumber86 commented Mar 23, 2017 • edited Loading

Slumber86 commented Mar 23, 2017

collinwu commented Mar 28, 2017

0-vortex commented Mar 29, 2017

piu130 commented Mar 29, 2017

pluswhite commented Apr 20, 2017

whawker Apr 28, 2017

Choose a reason for hiding this comment

prestonbernstein commented May 1, 2017

whawker May 2, 2017

Choose a reason for hiding this comment

matgessel May 9, 2017 • edited Loading

Choose a reason for hiding this comment

matgessel May 9, 2017 • edited Loading

Choose a reason for hiding this comment

matgessel May 9, 2017

Choose a reason for hiding this comment

freele May 16, 2017

Choose a reason for hiding this comment

dvdzkwsk commented May 16, 2017

rauleite commented Mar 9, 2017 •

edited

Loading

codecov-io commented Mar 9, 2017 •

edited

Loading

nathan-charrois commented Mar 16, 2017 •

edited

Loading

Slumber86 commented Mar 23, 2017 •

edited

Loading

matgessel May 9, 2017 •

edited

Loading

matgessel May 9, 2017 •

edited

Loading