Pure component notes #292
Pure component notes #292
Conversation
| @@ -34,11 +34,4 @@ describe('(Layout) Core', function () { | |||
| expect(_component.type).to.equal('div') | |||
| }) | |||
|
|
|||
| it('Should render a child component.', function () { | |||
There was a problem hiding this comment.
This is because the test utils don't work with pure components yet, right?
There was a problem hiding this comment.
exactly... do you want me to revert this commit to leave this as component class too?
There was a problem hiding this comment.
Not at all, was just making sure. And I'm not totally caught up to speed here: A regular React component class rendered inside of a pure component will still work w/ HMR, right?
There was a problem hiding this comment.
@davezuko yes all transforms are working, see below. i also tested hmr with multiple nested AboutViews to be sure react-transform is walking the full component tree 👍
There was a problem hiding this comment.
That would be amazing, and thanks for all the gifs, they help a lot!
resolves #277