Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Song Language #59

Closed
YoGo9 opened this issue Jan 29, 2025 · 2 comments · Fixed by #65
Closed

Setting Song Language #59

YoGo9 opened this issue Jan 29, 2025 · 2 comments · Fixed by #65
Assignees
Labels

Comments

@YoGo9
Copy link

YoGo9 commented Jan 29, 2025

It seems like the importer always assumes all songs are in Hebrew. Can this be changed? (If the API doesn't send this information, maybe a way to set lyrics language before importing?)

Example of an album with songs in English.

https://musicbrainz.org/release/026cda20-fa3b-4366-8e1f-cbc86edbf2fd/edit-relationships

https://nocs.acum.org.il/acumsitesearchdb/album?albumid=098621

@dvirtz
Copy link
Owner

dvirtz commented Jan 29, 2025

I take this from ACUM but it doesn't seem to be well populated unfortunately.

https://nocs.acum.org.il/acumsitesearchdb/getworkinfo?workId=1410432 has workLanguage: "1" which means Hebrew.
https://nocs.acum.org.il/acumsitesearchdb/getworkinfo?workId=2022911 has correct workLanguage: "2" which means to say just not Hebrew as far as I can see.

You can edit the language before submitting but I can look at making that configurable.

@dvirtz dvirtz self-assigned this Feb 4, 2025
dvirtz added a commit that referenced this issue Feb 4, 2025
@dvirtz dvirtz mentioned this issue Feb 4, 2025
@dvirtz dvirtz closed this as completed in #65 Feb 9, 2025
dvirtz added a commit that referenced this issue Feb 9, 2025
dvirtz-semantic-release bot pushed a commit that referenced this issue Feb 9, 2025
## [@dvirtz/acum-work-import-v1.12.0](https://github.com/dvirtz/musicbrainz-scripts/compare/@dvirtz/acum-work-import-v1.11.0...@dvirtz/acum-work-import-v1.12.0) (2025-02-09)

### Features

* get paged work versions ([b81038e](b81038e))
* import version from work UI ([74464d8](74464d8))
* make language setting optional ([b844a1c](b844a1c)), closes [#59](#59)
* support poetry works ([3259abc](3259abc))

### Bug Fixes

* empty pipeline error ([d49f72d](d49f72d))
* error when no existing work found ([9d4de46](9d4de46))
Copy link

github-actions bot commented Feb 9, 2025

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants