feat(linting-1): biome fixes

biome.json

@@ -9,36 +9,17 @@
       "linter": {
         "rules": {
           "complexity": {
-            "noBannedTypes": "off",
             "noForEach": "off",
-            "noThisInStatic": "off",
             "noUselessConstructor": "off",
-            "useLiteralKeys": "off",
-            "useOptionalChain": "off",
-            "useRegexLiterals": "off"
-          },
-          "correctness": {
-            "noInvalidUseBeforeDeclaration": "off",
-            "noVoidTypeReturn": "off",
-            "noSwitchDeclarations": "off"
+            "useLiteralKeys": "off"
           },
           "performance": {
-            "noAccumulatingSpread": "off",
             "noDelete": "off"
           },
           "suspicious": {
-            "noAssignInExpressions": "off",
             "noDoubleEquals": "off",
-            "noDuplicateTestHooks": "off",
             "noExplicitAny": "off",
-            "noImplicitAnyLet": "off",
-            "noPrototypeBuiltins": "off",
-            "noShadowRestrictedNames": "off",
             "useValidTypeof": "off"
-          },
-          "style": {
-            "noNonNullAssertion": "off",
-            "noParameterAssign": "off"
           }
         }
       }

src/app/accessible-autocomplete.d.ts

@@ -14,7 +14,7 @@ declare module 'accessible-autocomplete/dist/accessible-autocomplete.min' {
 		defaultValue?: string;
 		autoselect?: boolean;
 		showAllValues?: boolean;
-		dropdownArrow?: Function;
+		dropdownArrow?: () => unknown;
 	}
 
 	export interface AutocompleteParams extends DefaultParams, ElementParam {}

src/app/core/components/breadcrumbs/breadcrumbs.component.spec.ts

@@ -19,9 +19,7 @@ describe('BreadcrumbsComponent', () => {
 			imports: [RouterTestingModule],
 			providers: [RouterService, provideMockStore({ initialState: initialAppState })],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(BreadcrumbsComponent);
 		component = fixture.componentInstance;
 		store = TestBed.inject(MockStore);

src/app/core/components/footer/footer.component.spec.ts

@@ -10,9 +10,7 @@ describe('FooterComponent', () => {
 		await TestBed.configureTestingModule({
 			declarations: [FooterComponent],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(FooterComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/core/components/global-error/global-error.component.spec.ts

@@ -23,9 +23,7 @@ describe('GlobalErrorComponent', () => {
 			imports: [],
 			providers: [GlobalErrorService, provideMockStore({ initialState: initialAppState })],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(MockComponent);
 		component = fixture.debugElement.query(By.directive(GlobalErrorComponent)).componentInstance;
 		fixture.detectChanges();

src/app/core/components/global-warning/global-warning.component.spec.ts

@@ -20,12 +20,9 @@ describe('GlobalWarningComponent', () => {
 	beforeEach(async () => {
 		await TestBed.configureTestingModule({
 			declarations: [GlobalWarningComponent, MockComponent],
-			imports: [],
 			providers: [GlobalWarningService, provideMockStore({ initialState: initialAppState })],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(MockComponent);
 		component = fixture.debugElement.query(By.directive(GlobalWarningComponent)).componentInstance;
 		fixture.detectChanges();

src/app/core/components/header/header.component.spec.ts

@@ -13,9 +13,7 @@ describe('HeaderComponent', () => {
 		await TestBed.configureTestingModule({
 			declarations: [HeaderComponent],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(HeaderComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/core/components/page-not-found/page-not-found.component.spec.ts

@@ -9,9 +9,7 @@ describe('PageNotFoundComponent', () => {
 		await TestBed.configureTestingModule({
 			declarations: [PageNotFoundComponent],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(PageNotFoundComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/core/components/phase-banner/phase-banner.component.spec.ts

@@ -10,9 +10,7 @@ describe('PhaseBannerComponent', () => {
 		await TestBed.configureTestingModule({
 			declarations: [PhaseBannerComponent],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(PhaseBannerComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/core/components/server-error/server-error.component.spec.ts

@@ -9,9 +9,7 @@ describe('ServerErrorComponent', () => {
 		await TestBed.configureTestingModule({
 			declarations: [ServerErrorComponent],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(ServerErrorComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/features/home/components/home-button/home-button.component.spec.ts

@@ -11,9 +11,7 @@ describe('HomeButtonComponent', () => {
 			declarations: [HomeButtonComponent],
 			imports: [RouterTestingModule],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(HomeButtonComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/features/home/home.component.spec.ts

@@ -31,9 +31,7 @@ describe('HomeComponent', () => {
 				},
 			],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(HomeComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/features/reference-data/reference-data-add/reference-data-add.component.spec.ts

@@ -36,9 +36,7 @@ describe('ReferenceDataCreateComponent', () => {
 				{ provide: ReferenceDataService, useValue: mockRefDataService },
 			],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		store = TestBed.inject(MockStore);
 		fixture = TestBed.createComponent(ReferenceDataCreateComponent);
 		component = fixture.componentInstance;

src/app/features/reference-data/reference-data-amend-history/reference-data-amend-history.component.spec.ts

@@ -21,9 +21,7 @@ describe('ReferenceDataAmendHistoryComponent', () => {
 				{ provide: UserService, useValue: {} },
 			],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(ReferenceDataAmendHistoryComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/features/reference-data/reference-data-amend/reference-data-amend.component.spec.ts

@@ -34,9 +34,7 @@ describe('ReferenceDataAmendComponent', () => {
 				{ provide: ReferenceDataService, useValue: mockRefDataService },
 			],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		store = TestBed.inject(MockStore);
 		fixture = TestBed.createComponent(ReferenceDataAmendComponent);
 		component = fixture.componentInstance;

src/app/features/reference-data/reference-data-delete/reference-data-delete.component.spec.ts

@@ -29,9 +29,7 @@ describe('ReferenceDataAddComponent', () => {
 				{ provide: UserService, useValue: {} },
 			],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		store = TestBed.inject(MockStore);
 		fixture = TestBed.createComponent(ReferenceDataDeleteComponent);
 		component = fixture.componentInstance;
@@ -44,6 +42,7 @@ describe('ReferenceDataAddComponent', () => {
 	it('should create', () => {
 		expect(component).toBeTruthy();
 	});
+
 	describe('navigateBack', () => {
 		it('should clear all errors', () => {
 			jest.spyOn(router, 'navigate').mockImplementation();

src/app/features/reference-data/reference-data-deleted-list/reference-data-deleted-list.component.spec.ts

@@ -31,9 +31,7 @@ describe('DataTypeListComponent', () => {
 				},
 			],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(ReferenceDataDeletedListComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/features/reference-data/reference-data-list/reference-data-list.component.spec.ts

@@ -34,9 +34,7 @@ describe('DataTypeListComponent', () => {
 				{ provide: UserService, useValue: { roles$: of([Roles.ReferenceDataView]) } },
 			],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(ReferenceDataListComponent);
 		component = fixture.componentInstance;
 		route = TestBed.inject(ActivatedRoute);

src/app/features/reference-data/reference-data-select-type/reference-data-select-type.component.spec.ts

@@ -32,9 +32,7 @@ describe('ReferenceDataComponent', () => {
 				{ provide: UserService, useValue: { roles$: of([Roles.ReferenceDataView]) } },
 			],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(ReferenceDataSelectTypeComponent);
 		component = fixture.componentInstance;
 		router = TestBed.inject(Router);

src/app/features/search/search.component.spec.ts

@@ -28,9 +28,7 @@ describe('SearchComponent', () => {
 			imports: [HttpClientTestingModule, RouterTestingModule],
 			providers: [GlobalErrorService, TechnicalRecordService, provideMockStore({ initialState: initialAppState })],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		store = TestBed.inject(MockStore);
 		store.overrideSelector(globalErrorState, expectedErrors);
 		fixture = TestBed.createComponent(SearchComponent);

src/app/features/search/search.component.ts

@@ -27,14 +27,15 @@ export class SearchComponent {
 		this.globalErrorService.clearErrors();
 		this.store.dispatch(clearAllSectionStates());
 		this.store.dispatch(clearScrollPosition());
-		term = term.trim();
 
-		if (!term) {
+		const formattedTerm = term.trim();
+
+		if (!formattedTerm) {
 			this.globalErrorService.addError({ error: this.missingTermErrorMessage, anchorLink: 'search-term' });
 		} else if (!Object.values(SEARCH_TYPES).includes(type as SEARCH_TYPES)) {
 			this.globalErrorService.addError({ error: this.missingTypeErrorMessage, anchorLink: 'search-type' });
 		} else {
-			void this.router.navigate(['/search/results'], { queryParams: { [type]: term } });
+			void this.router.navigate(['/search/results'], { queryParams: { [type]: formattedTerm } });
 		}
 	}
 

src/app/features/search/single-search-result/single-search-result.component.spec.ts

@@ -31,9 +31,7 @@ describe('SingleSearchResultComponent', () => {
 				},
 			],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(SingleSearchResultComponent);
 		component = fixture.componentInstance;
 		component.searchResult = {

src/app/features/tech-record/components/adr-generate-certificate/adr-generate-certificate.component.spec.ts

@@ -33,8 +33,8 @@ describe('AdrGenerateCertificateComponent', () => {
 	let store: MockStore;
 	let technicalRecordService: TechnicalRecordService;
 
-	beforeEach(async () => {
-		await TestBed.configureTestingModule({
+	beforeEach(() => {
+		TestBed.configureTestingModule({
 			declarations: [AdrGenerateCertificateComponent],
 			providers: [
 				GlobalErrorService,
@@ -52,8 +52,7 @@ describe('AdrGenerateCertificateComponent', () => {
 			],
 			imports: [RouterTestingModule, SharedModule, ReactiveFormsModule, DynamicFormsModule, HttpClientTestingModule],
 		}).compileComponents();
-	});
-	beforeEach(() => {
+
 		fixture = TestBed.createComponent(AdrGenerateCertificateComponent);
 		errorService = TestBed.inject(GlobalErrorService);
 		route = TestBed.inject(ActivatedRoute);

src/app/features/tech-record/components/adr-generate-certificate/adr-generate-certificate.component.ts

@@ -75,12 +75,15 @@ export class AdrGenerateCertificateComponent implements OnInit, OnDestroy {
 
 	handleSubmit(): void {
 		this.globalErrorService.clearErrors();
+
 		if (!this.form.value.certificateType) {
-			return this.globalErrorService.addError({
+			this.globalErrorService.addError({
 				error: 'ADR Certificate Type is required',
 				anchorLink: 'certificateType',
 			});
+			return;
 		}
+
 		this.store.dispatch(
 			generateADRCertificate({
 				systemNumber: this.systemNumber ?? '',

src/app/features/tech-record/components/edit-tech-record-button/edit-tech-record-button.component.spec.ts

@@ -63,9 +63,7 @@ describe('EditTechRecordButtonComponent', () => {
 			],
 			imports: [DynamicFormsModule, HttpClientTestingModule, RouterTestingModule, SharedModule],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(EditTechRecordButtonComponent);
 		router = TestBed.inject(Router);
 		store = TestBed.inject(MockStore);

src/app/features/tech-record/components/tech-record-amend-reason/tech-record-amend-reason.component.spec.ts

@@ -28,9 +28,7 @@ describe('TechRecordAmendReasonComponent', () => {
 
 		route = TestBed.inject(ActivatedRoute);
 		router = TestBed.inject(Router);
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(TechRecordAmendReasonComponent);
 		component = fixture.componentInstance;
 		fixture.detectChanges();

src/app/features/tech-record/components/tech-record-amend-vin/tech-record-amend-vin.component.spec.ts

@@ -55,9 +55,7 @@ describe('TechRecordChangeVinComponent', () => {
 			],
 			imports: [RouterTestingModule, SharedModule, ReactiveFormsModule, DynamicFormsModule],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(AmendVinComponent);
 		errorService = TestBed.inject(GlobalErrorService);
 		route = TestBed.inject(ActivatedRoute);

src/app/features/tech-record/components/tech-record-amend-vrm-reason/tech-record-amend-vrm-reason.component.spec.ts

@@ -39,9 +39,7 @@ describe('TechRecordChangeVrmComponent', () => {
 			],
 			imports: [RouterTestingModule, SharedModule, ReactiveFormsModule, DynamicFormsModule, HttpClientTestingModule],
 		}).compileComponents();
-	});
 
-	beforeEach(() => {
 		fixture = TestBed.createComponent(AmendVrmReasonComponent);
 		errorService = TestBed.inject(GlobalErrorService);
 		router = TestBed.inject(Router);