feat(cb2-15038): allow current year +1 for year of manufacture #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomcrawleyy
approved these changes
Nov 11, 2024
tomevs88
approved these changes
Nov 11, 2024
pbardy2000
added a commit
that referenced
this pull request
Nov 14, 2024
* chore(cb2-0000): basic form * chore(cb2-0000): changes * chore(cb2-0000): add view and summary mode * chore(cb2-0000): add example directive * chore(cb2-0000): add dates and directives * chore(cb2-0000): adr section changes * chore(cb2-0000): fix issues with global error service * chore(cb2-0000): fix validation for ADR section * chore(cb2-0000): fix tc3 validator * chore(cb2-0000): general ADR section fixes * chore(cb2-0000): allow editing fields on different pages * chore(cb2-0000): replicate behaviour around explosives * chore(cb2-0000): fix unit tests * feat(cb2-14457): migrate styles and directives over * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): add automation ids * feat(cb2-14457): amend review screen * feat(cb2-14457): convert inputs to gds format * feat(cb2-14457): add body declaration * feat(cb2-14457): add ids to input labels * feat(cb2-14457): migrate last of inputs to gds * feat(cb2-14457): more radios * feat(cb2-15038): allow current year +1 for year of manufacture (#1639) * feat(cb2-14457): final radio * feat(cb2-14457): make dates less verbose * feat(cb2-14457): checkbox styling and small fixes * feat(cb2-14457): checkbox styling * feat(cb2-14457): directives rework * feat(cb2-14457): selects refactored * feat(cb2-14457): fix date errors * feat(cb2-14457): text area refactor * feat(cb2-14457): introduce styling for dates * feat(cb2-14457): label cleanup * feat(cb2-14457): fix date styling and unit tests --------- Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk>
cvs-ops
pushed a commit
that referenced
this pull request
Nov 14, 2024
* chore(cb2-0000): basic form * chore(cb2-0000): changes * chore(cb2-0000): add view and summary mode * chore(cb2-0000): add example directive * chore(cb2-0000): add dates and directives * chore(cb2-0000): adr section changes * chore(cb2-0000): fix issues with global error service * chore(cb2-0000): fix validation for ADR section * chore(cb2-0000): fix tc3 validator * chore(cb2-0000): general ADR section fixes * chore(cb2-0000): allow editing fields on different pages * chore(cb2-0000): replicate behaviour around explosives * chore(cb2-0000): fix unit tests * feat(cb2-14457): migrate styles and directives over * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): add automation ids * feat(cb2-14457): amend review screen * feat(cb2-14457): convert inputs to gds format * feat(cb2-14457): add body declaration * feat(cb2-14457): add ids to input labels * feat(cb2-14457): migrate last of inputs to gds * feat(cb2-14457): more radios * feat(cb2-15038): allow current year +1 for year of manufacture (#1639) * feat(cb2-14457): final radio * feat(cb2-14457): make dates less verbose * feat(cb2-14457): checkbox styling and small fixes * feat(cb2-14457): checkbox styling * feat(cb2-14457): directives rework * feat(cb2-14457): selects refactored * feat(cb2-14457): fix date errors * feat(cb2-14457): text area refactor * feat(cb2-14457): introduce styling for dates * feat(cb2-14457): label cleanup * feat(cb2-14457): fix date styling and unit tests --------- Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk>
pbardy2000
added a commit
that referenced
this pull request
Nov 25, 2024
* chore(cb2-0000): basic form * chore(cb2-0000): changes * chore(cb2-0000): add view and summary mode * chore(cb2-0000): add example directive * chore(cb2-0000): add dates and directives * chore(cb2-0000): adr section changes * chore(cb2-0000): fix issues with global error service * chore(cb2-0000): fix validation for ADR section * chore(cb2-0000): fix tc3 validator * chore(cb2-0000): general ADR section fixes * chore(cb2-0000): allow editing fields on different pages * chore(cb2-0000): replicate behaviour around explosives * chore(cb2-0000): fix unit tests * feat(cb2-14457): migrate styles and directives over * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): add automation ids * feat(cb2-14457): amend review screen * feat(cb2-14457): convert inputs to gds format * feat(cb2-14457): add body declaration * feat(cb2-14457): add ids to input labels * feat(cb2-14457): migrate last of inputs to gds * feat(cb2-14457): more radios * feat(cb2-14457): final radio * feat(cb2-14457): make dates less verbose * feat(cb2-14457): checkbox styling and small fixes * feat(cb2-14457): checkbox styling * feat(cb2-14457): directives rework * feat(cb2-14457): selects refactored * feat(cb2-14457): fix date errors * feat(cb2-14457): text area refactor * feat(cb2-14457): introduce styling for dates * feat(cb2-14457): label cleanup * feat(cb2-14457): fix date styling and unit tests * Feat/cb2 14457 (#1642) * chore(cb2-0000): basic form * chore(cb2-0000): changes * chore(cb2-0000): add view and summary mode * chore(cb2-0000): add example directive * chore(cb2-0000): add dates and directives * chore(cb2-0000): adr section changes * chore(cb2-0000): fix issues with global error service * chore(cb2-0000): fix validation for ADR section * chore(cb2-0000): fix tc3 validator * chore(cb2-0000): general ADR section fixes * chore(cb2-0000): allow editing fields on different pages * chore(cb2-0000): replicate behaviour around explosives * chore(cb2-0000): fix unit tests * feat(cb2-14457): migrate styles and directives over * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): add automation ids * feat(cb2-14457): amend review screen * feat(cb2-14457): convert inputs to gds format * feat(cb2-14457): add body declaration * feat(cb2-14457): add ids to input labels * feat(cb2-14457): migrate last of inputs to gds * feat(cb2-14457): more radios * feat(cb2-15038): allow current year +1 for year of manufacture (#1639) * feat(cb2-14457): final radio * feat(cb2-14457): make dates less verbose * feat(cb2-14457): checkbox styling and small fixes * feat(cb2-14457): checkbox styling * feat(cb2-14457): directives rework * feat(cb2-14457): selects refactored * feat(cb2-14457): fix date errors * feat(cb2-14457): text area refactor * feat(cb2-14457): introduce styling for dates * feat(cb2-14457): label cleanup * feat(cb2-14457): fix date styling and unit tests --------- Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk> * feat(cb2-14457): don't override element id * feat(cb2-14457): remove id and name * feat(cb2-14457): remove id and name (#1643) Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): add checkbox to ids * Feat/cb2 14457 (#1644) * feat(cb2-14457): remove id and name * feat(cb2-14457): add checkbox to ids --------- Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): character count id fix * Feat/cb2 14457 - text area id's (#1645) * feat(cb2-14457): remove id and name * feat(cb2-14457): add checkbox to ids * feat(cb2-14457): character count id fix --------- Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): character count corrections * feat(cb2-14457): add additional details * feat(cb2-14457): resolve validator message mismatch * feat/cb2-14457 (#1646) * feat(cb2-14457): remove id and name * feat(cb2-14457): add checkbox to ids * feat(cb2-14457): character count id fix * feat(cb2-14457): character count corrections * feat(cb2-14457): add additional details * feat(cb2-14457): resolve validator message mismatch --------- Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): amend additional examiner notes validator * Feat/cb2 14457 (#1647) * feat(cb2-14457): remove id and name * feat(cb2-14457): add checkbox to ids * feat(cb2-14457): character count id fix * feat(cb2-14457): character count corrections * feat(cb2-14457): add additional details * feat(cb2-14457): resolve validator message mismatch * feat(cb2-14457): amend additional examiner notes validator --------- Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): more additional examiner notes amendments * feat(cb2-14457): add ids to inline error messages * feat(cb2-14457): change to using element id, use correct id in label fors * feat(cb2-14457): fix labels * feat(cb2-14457): fix battery list applicable validation * feat(cb2-14457): test * feat(cb2-14457): fix error messages for automation pack * feat(cb2-14457): fix ADR specific issues * feat(cb2-14457): correct max length validation * feat(cb2-14457): correct more messages * feat(cb2-14457): fix batch plating * feat(cb2-14457): change wording * feat(cb2-14457): fix spelling * feat(cb2-14457): change date validation * feat(cb2-14457): year must be four digits * feat(cb2-14457): fix discrepancies with develop * feat(cb2-14457): add missing details * feat(cb2-14457): only show brake endurance with issue section * feat(cb2-14457): show brake endurance with issuer * feat(cb2-14457): improvments * feat(cb2-14457): improvments again * feat(cb2-14457): change conditions for displaying ADR details message * feat(cb2-14457): turn flags on --------- Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
tomcrawleyy
added a commit
that referenced
this pull request
Nov 25, 2024
* chore(cb2-0000): basic form * chore(cb2-0000): changes * chore(cb2-0000): add view and summary mode * chore(cb2-0000): add example directive * chore(cb2-0000): add dates and directives * chore(cb2-0000): adr section changes * chore(cb2-0000): fix issues with global error service * chore(cb2-0000): fix validation for ADR section * chore(cb2-0000): fix tc3 validator * chore(cb2-0000): general ADR section fixes * chore(cb2-0000): allow editing fields on different pages * chore(cb2-0000): replicate behaviour around explosives * chore(cb2-0000): fix unit tests * feat(cb2-14457): migrate styles and directives over * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): add automation ids * feat(cb2-14457): amend review screen * feat(cb2-14457): convert inputs to gds format * feat(cb2-14457): add body declaration * feat(cb2-14457): add ids to input labels * feat(cb2-14457): migrate last of inputs to gds * feat(cb2-14457): more radios * feat(cb2-14457): final radio * feat(cb2-14457): make dates less verbose * feat(cb2-14457): checkbox styling and small fixes * feat(cb2-14457): checkbox styling * feat(cb2-14457): directives rework * feat(cb2-14457): selects refactored * feat(cb2-14457): fix date errors * feat(cb2-14457): text area refactor * feat(cb2-14457): introduce styling for dates * feat(cb2-14457): label cleanup * feat(cb2-14457): fix date styling and unit tests * Feat/cb2 14457 (#1642) * chore(cb2-0000): basic form * chore(cb2-0000): changes * chore(cb2-0000): add view and summary mode * chore(cb2-0000): add example directive * chore(cb2-0000): add dates and directives * chore(cb2-0000): adr section changes * chore(cb2-0000): fix issues with global error service * chore(cb2-0000): fix validation for ADR section * chore(cb2-0000): fix tc3 validator * chore(cb2-0000): general ADR section fixes * chore(cb2-0000): allow editing fields on different pages * chore(cb2-0000): replicate behaviour around explosives * chore(cb2-0000): fix unit tests * feat(cb2-14457): migrate styles and directives over * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): attempt at using new styles and directive * feat(cb2-14457): add automation ids * feat(cb2-14457): amend review screen * feat(cb2-14457): convert inputs to gds format * feat(cb2-14457): add body declaration * feat(cb2-14457): add ids to input labels * feat(cb2-14457): migrate last of inputs to gds * feat(cb2-14457): more radios * feat(cb2-15038): allow current year +1 for year of manufacture (#1639) * feat(cb2-14457): final radio * feat(cb2-14457): make dates less verbose * feat(cb2-14457): checkbox styling and small fixes * feat(cb2-14457): checkbox styling * feat(cb2-14457): directives rework * feat(cb2-14457): selects refactored * feat(cb2-14457): fix date errors * feat(cb2-14457): text area refactor * feat(cb2-14457): introduce styling for dates * feat(cb2-14457): label cleanup * feat(cb2-14457): fix date styling and unit tests --------- Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk> * feat(cb2-14457): don't override element id * feat(cb2-14457): remove id and name * feat(cb2-14457): remove id and name (#1643) Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): add checkbox to ids * Feat/cb2 14457 (#1644) * feat(cb2-14457): remove id and name * feat(cb2-14457): add checkbox to ids --------- Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): character count id fix * Feat/cb2 14457 - text area id's (#1645) * feat(cb2-14457): remove id and name * feat(cb2-14457): add checkbox to ids * feat(cb2-14457): character count id fix --------- Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): character count corrections * feat(cb2-14457): add additional details * feat(cb2-14457): resolve validator message mismatch * feat/cb2-14457 (#1646) * feat(cb2-14457): remove id and name * feat(cb2-14457): add checkbox to ids * feat(cb2-14457): character count id fix * feat(cb2-14457): character count corrections * feat(cb2-14457): add additional details * feat(cb2-14457): resolve validator message mismatch --------- Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): amend additional examiner notes validator * Feat/cb2 14457 (#1647) * feat(cb2-14457): remove id and name * feat(cb2-14457): add checkbox to ids * feat(cb2-14457): character count id fix * feat(cb2-14457): character count corrections * feat(cb2-14457): add additional details * feat(cb2-14457): resolve validator message mismatch * feat(cb2-14457): amend additional examiner notes validator --------- Co-authored-by: pbardy2000 <146740183+pbardy2000@users.noreply.github.com> * feat(cb2-14457): more additional examiner notes amendments * feat(cb2-14457): add ids to inline error messages * feat(cb2-14457): change to using element id, use correct id in label fors * feat(cb2-14457): fix labels * feat(cb2-14457): fix battery list applicable validation * feat(cb2-14457): test * feat(cb2-14457): fix error messages for automation pack * feat(cb2-14457): fix ADR specific issues * feat(cb2-14457): correct max length validation * feat(cb2-14457): correct more messages * feat(cb2-14457): fix batch plating * feat(cb2-14457): change wording * feat(cb2-14457): fix spelling * feat(cb2-14457): change date validation * feat(cb2-14457): year must be four digits * feat(cb2-14457): fix discrepancies with develop * feat(cb2-14457): add missing details * feat(cb2-14722): fix displaying of additional defects on test history (#1652) * feat(cb2-14457): only show brake endurance with issue section * feat(cb2-14457): show brake endurance with issuer * feat(cb2-14457): improvments * feat(cb2-14457): improvments again * feat(cb2-14457): change conditions for displaying ADR details message * feat(cb2-14457): turn flags on * Revert "Merge branch 'develop' into feat/cb2-14457" This reverts commit de4f62e, reversing changes made to 70000bb. * feat(cb2-14457): update vtm version number --------- Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk> Co-authored-by: Brandon Thomas-Davies <87308252+BrandonT95@users.noreply.github.com> Co-authored-by: Tom Evans <thomas.evans@dvsa.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VTM - Allow year of manufacture input field to accept one year into the future when creating/amending technical records
CB2-15038
Checklist