Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cb2-14450-weights-dfs): weights and tyres #1735

Merged
merged 251 commits into from
Jan 22, 2025
Merged

feat(cb2-14450-weights-dfs): weights and tyres #1735

merged 251 commits into from
Jan 22, 2025

Conversation

pbardy2000
Copy link
Contributor

Refactor DFS - Weights

CB2-14450

Checklist

  • Branch is rebased against the latest develop/common
  • Code and UI has been tested manually after the additional changes
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Delete branch after merge

pbardy2000 and others added 30 commits September 18, 2024 14:04
@pbardy2000
chore(cb2-0000): changes
71fd840
@pbardy2000
chore(cb2-0000): add view and summary mode
d0f4abc
@pbardy2000
chore(cb2-0000): add example directive
f28a586
@BrandonT95
chore(cb2-0000): initial implementation of vehicle summary section
153e671
@pbardy2000
chore(cb2-0000): add dates and directives
47b3951
@BrandonT95
Merge branch 'chore/dfs-poc-phil' into chore/poc-vehicle-section
50f8e60
@BrandonT95
chore(cb2-0000): rebase and lint
edf63af
@tomcrawleyy
chore(cb2-0000): additional vehicle section properties
604cf10
@tomcrawleyy
feat(cb2-0000): add additional directives
9949212
@pbardy2000
chore(cb2-0000): adr section changes
e165d39
@pbardy2000
Merge branch 'develop' into chore/dfs-poc-phil
f441cb5
@pbardy2000
chore(cb2-0000): fix issues with global error service
c74744d
@pbardy2000
Merge branch 'chore/dfs-poc-phil' into chore/poc-vehicle-section
0ca87d0
@pbardy2000
chore(cb2-0000): fix linting
8aa5a8b
@pbardy2000
chore(cb2-0000): fix validation for ADR section
a6c9303
@pbardy2000
chore(cb2-0000): fix tc3 validator
38be6e1
@BrandonT95
Merge branch 'chore/dfs-poc-phil' into chore/poc-vehicle-section
f276392
@BrandonT95
chore(cb2-0000): commit progress on vehicle summary
6a04365
@tomcrawleyy
chore(poc-vehicle-section): hgv options and accessibility refactor
b05a454
@pbardy2000
chore(cb2-0000): general ADR section fixes
d542534
@BrandonT95
chore(cb2-0000): attempt at adding controls based off vehicle type
422b21c
@BrandonT95
chore(cb2-0000): attempt at adding controls based off vehicle type im…
c6417d3 
…provements
@BrandonT95
chore(cb2-0000): improve form typing
5ed5d1a
@tomcrawleyy
feat(cb2-0000): migrate remaining elements to new accessibility syntax
13115da
@BrandonT95
chore(cb2-0000): move vehicle class based off vehicle type
2e5664a
@tomcrawleyy
feat(cb2-0000): styling POC
40547fa
@pbardy2000
chore(cb2-0000): styling fixes
c9bf763
@pbardy2000
chore(cb2-0000): allow editing fields on different pages
e62ce51
@BrandonT95
Merge branch 'chore/dfs-poc-phil' into chore/poc-vehicle-section
804ed36
@tomcrawleyy
feat(cb2-0000): update to use new global scss styles
3308641
BrandonT95 and others added 22 commits January 8, 2025 09:14
@BrandonT95
feat(cb2-14450): add some unit tests
bb43679
@pbardy2000
fix(CB2-15820): add plates tag to tyre use code (#1707)
8bab3e4
@pbardy2000
Merge branch 'feat/CB2-14452-tyres-dfs' into feat/CB2-14450-weights-dfs
e66ff70
@tomcrawleyy
feat(CB2-14450-weights-dfs): tyres unit tests fix
259946d
@pbardy2000 @tomcrawleyy
Feat/cb2 14452 tyres dfs temp (#1710)
b16ca51 
* feat(CB2-14452-tyres-dfs-temp): add back changes that were reverted

* feat(CB2-14450-weights-dfs): tyres unit tests fix

---------

Co-authored-by: Thomas Crawley <thomas.crawley@dvsa.gov.uk>
@tomcrawleyy
Merge branch 'feat/CB2-14452-tyres-dfs' into feat/CB2-14450-weights-dfs
56e9fad
@tomcrawleyy
feat(CB2-14450-weights-dfs): push label fix for tyres on view and sum…
08470e0 
…mary
@pbardy2000
fix(CB2-15824): fix tyre use code styling on review page (#1708)
e401243
@pbardy2000
fix(CB2-15821): fix interaction with weights (#1714)
f4858fa 
* fix(CB2-15821): fixes for axles

* fix(CB2-15821): fixes for interaction with tyres

* fix(CB2-15821): remove console log

* fix(CB2-15821): fix weights for psv
@pbardy2000
feat(CB2-14450-weights-dfs): remove tyre axle merging issue
5bc8182
@tomcrawleyy
feat(CB2-14450): implement interface for on changes
638b8e2
@pbardy2000
feat(CB2-14450-weights-dfs): fix axle removal issues
3a3d2a9
@tomcrawleyy
feat(CB2-14450): use default null or empty pipe in tables for view an…
0a1ec87 
…d summary
@pbardy2000
feat(CB2-14450-weights-dfs): prevent duplication of ids
09cd96d
@pbardy2000
feat(CB2-14450-weights-dfs): display inline error message
f3531cb
@pbardy2000
Merge branch 'develop' into feat/CB2-14450-weights-dfs
2dd9eb3
@pbardy2000
feat(CB2-14450-weights-dfs): remove unit test
99df9fa
@tomcrawleyy
fix/CB2-15894 - Resolve speed category symbol issues (#1720)
2d585e6 
* fix(CB2-15894): initial commit

* fix(CB2-15894): stash

* fix(CB2-15894): remove console logs and fix the issue

* fix(CB2-15894): better code

* fix(CB2-15894): remove console log
@pbardy2000
feat(CB2-14450-weights-dfs): change axle weights title on summary
9cb8677
@tomcrawleyy
feat/CB2-15892 - Remove axle weight warning from view mode (#1725)
b8646dc 
* feat(CB2-15892): remove warning from view mode

* feat(CB2-15892): remove accompanying method

* feat(CB2-15892): remove more redundant code
@BrandonT95
feat(cb2-15983): dont show table if no axles exist or no changes made (…
e8880f1 
…#1727)
@BrandonT95
feat(cb2-15989): change the table header text to match dev (#1733)
2de0e82
@github-actions github-actions bot added the enhancement New feature or request label Jan 21, 2025
@pbardy2000 pbardy2000 mentioned this pull request Jan 21, 2025
Closed
5 tasks
@pbardy2000 pbardy2000 merged commit 6850c40 into develop Jan 22, 2025
11 checks passed
@pbardy2000 pbardy2000 deleted the feat/CB2-14450-weights-dfs branch January 22, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomcrawleyy tomcrawleyy tomcrawleyy approved these changes

@BrandonT95 BrandonT95 BrandonT95 approved these changes

Assignees

@pbardy2000 pbardy2000

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbardy2000 @tomcrawleyy @BrandonT95