Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cb2 10594 - add upsert functionality for (tech-record's) ADR-Details attributes #79

Open
wants to merge 47 commits into
base: develop
Choose a base branch
from

Conversation

meys-bjss
Copy link

Description

Updating the update-store's upsert functionality for ADR attributes so that it stores the ADR Details attributes into NOP tables.

Related issue:
CB2-10594
CB2-10593
CB2-10592

Useful links:
https://dvsa.atlassian.net/wiki/spaces/HVT/pages/382011842/ADR+Section
https://dvsa.atlassian.net/wiki/spaces/HVT/pages/494174610/SPIKE+Validate+existing+update-store+functionality+for+ADR
https://dvsa.atlassian.net/wiki/spaces/HVT/pages/493781660/CB2-10450+-+SPIKE+Compare+NOP+ADR+data+model+to+Dynamo

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@meys-bjss meys-bjss changed the title Feature/cb2 10594 Feature/cb2 10594 - add upsert functionality for (tech-record's) ADR-Details attributes Feb 8, 2024
Meys Torkaman and others added 24 commits February 9, 2024 09:53
* rectifying data type mismatches, add un-defined Enums and attributes, adding in-line comments

* add AdrCertificateDetails interface and parsing function

* adding guidanceNotes Enum

* adding m145 attribute as per documentation change

* feat: adr details added, test resource for technoical record added, unit test added

* style: rearrange enums

* fix: replace ! with ? for optional attributes

* fix: memosApplyEnum value updated

* fix: 2 new attributes added to adrDetails, as per documentation

* feat: tab le definition

* fix: enum updated

* feat: adr tables added to the tech record list of tables

* feat: new function added for partial upsert based on condition attribute

* feat: some adr table detail updated

* feat: upsert fun ctionality added for adr-details attributes in tech record

* feat: adr parts added to tech record integration test

* feat: docker's mysql image updated to version 8 - consistent with recent RDS engine upgarde for NOP

* feat: adr attribute values updated

* feat: test updated as adr attribute values updated in json file

* fix: changes reverted back to original

* fix: changes reverted back to original

* fix: changes reverted back to original

* feat: cleaning and bringing in adr pass certificate

* feat: cleaning and bringing in adr pass certificate

* feat: cleaning and bringing in adr pass certificate

* fix: removed async keyword to avoid error when running the test

* fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo

* fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo

* fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo

* fix: updating adr pass certificate function

* fix: updating adr pass certificate field name

* fix: updating adr pass certificate var name

* feat: adding integration tests for additional test scenarios

* feat: adding adr pass certificate attribute

* feat: adding adr pass certificate attribute test to unit test

* fix: syntax fixed

---------

Co-authored-by: Meys Torkaman <meys.torkaman@MacBook-Pro.local>
Co-authored-by: meys-bjss <140601718+meys-bjss@users.noreply.github.com>
* rectifying data type mismatches, add un-defined Enums and attributes, adding in-line comments

* add AdrCertificateDetails interface and parsing function

* adding guidanceNotes Enum

* adding m145 attribute as per documentation change

* feat: adr details added, test resource for technoical record added, unit test added

* style: rearrange enums

* fix: replace ! with ? for optional attributes

* fix: memosApplyEnum value updated

* fix: 2 new attributes added to adrDetails, as per documentation

* feat: tab le definition

* fix: enum updated

* feat: adr tables added to the tech record list of tables

* feat: new function added for partial upsert based on condition attribute

* feat: some adr table detail updated

* feat: upsert fun ctionality added for adr-details attributes in tech record

* feat: adr parts added to tech record integration test

* feat: docker's mysql image updated to version 8 - consistent with recent RDS engine upgarde for NOP

* feat: adr attribute values updated

* feat: test updated as adr attribute values updated in json file

* fix: changes reverted back to original

* fix: changes reverted back to original

* fix: changes reverted back to original

* feat: cleaning and bringing in adr pass certificate

* feat: cleaning and bringing in adr pass certificate

* feat: cleaning and bringing in adr pass certificate

* fix: removed async keyword to avoid error when running the test

* fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo

* fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo

* fix: bringing in to be able to run integration tests on my mac and be able to push changes into repo

* fix: updating adr pass certificate function

* fix: updating adr pass certificate field name

* fix: updating adr pass certificate var name

* feat: adding integration tests for additional test scenarios

* feat: adding adr pass certificate attribute

* feat: adding adr pass certificate attribute test to unit test

* fix: syntax fixed

* fix: updating for tank statement attributes, add conditions for missing attributes

* fix: updating for tank statement attributes

* fix: updating for tank statement attributes

* fix: updating for tank statement attributes

* fix: updating for tank statement attributes

---------

Co-authored-by: Meys Torkaman <meys.torkaman@MacBook-Pro.local>
Co-authored-by: meys-bjss <140601718+meys-bjss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants