patch(cb2-9603): split 'small series' into separate options to accom… (…

…#128) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dvsa · Oct 26, 2023 · c1b3fcf · c1b3fcf
1 parent 2b0a124
commit c1b3fcf
Show file tree

Hide file tree

Showing 46 changed files with 139 additions and 69 deletions.
diff --git a/README.md b/README.md
@@ -40,6 +40,12 @@ TypeScript interfaces will be generated from these files and saved to `types` di
 4. Bump the version of the package using `npm version {major|minor|patch}`
 5. Publish updates
 
+# Creating a new enum
+1. Add (or update) the enum to a file marked `*.enum.json` in the `enum` folder in `json-definitions`
+2. Make sure you give it both `enum` and `tsEnumNames` properties on the object
+3. Then update the `json-definitions` to use the new file name
+4. Run the generate and you should have just a new file in the enum folder of types, which is exportable and useable.
+
 # Publishing a new version
 
 - Raise a PR

diff --git a/json-definitions/v3/tech-record/enums/approvalType.enum.json b/json-definitions/v3/tech-record/enums/approvalType.enum.json
@@ -13,7 +13,8 @@
     "EU_WVTA_23_ON",
     "QNIG",
     "PROV_GB_WVTA",
-    "SMALL_SERIES",
+    "SMALL_SERIES_NKSXX",
+    "SMALL_SERIES_NKS",
     "IVA_VCA",
     "IVA_DVSA_NI"
   ],
@@ -29,7 +30,8 @@
     "EU WVTA 23 on",
     "QNIG",
     "Prov.GB WVTA",
-    "Small series",
+    "Small series NKSXX",
+    "Small series NKS",
     "IVA - VCA",
     "IVA - DVSA/NI"
   ]

diff --git a/json-definitions/v3/tech-record/enums/approvalTypeHgvOrPsv.enum.json b/json-definitions/v3/tech-record/enums/approvalTypeHgvOrPsv.enum.json
@@ -9,7 +9,8 @@
     "ECSSTA",
     "GB_WVTA",
     "PROV_GB_WVTA",
-    "SMALL_SERIES",
+    "SMALL_SERIES_NKSXX",
+    "SMALL_SERIES_NKS",
     "IVA_VCA",
     "IVA_DVSA_NI"
   ],
@@ -21,7 +22,8 @@
     "ECSSTA",
     "GB WVTA",
     "Prov.GB WVTA",
-    "Small series",
+    "Small series NKSXX",
+    "Small series NKS",
     "IVA - VCA",
     "IVA - DVSA/NI"
   ]

diff --git a/json-schemas/v3/tech-record/enums/approvalType.enum.json b/json-schemas/v3/tech-record/enums/approvalType.enum.json
@@ -13,7 +13,8 @@
 		"EU_WVTA_23_ON",
 		"QNIG",
 		"PROV_GB_WVTA",
-		"SMALL_SERIES",
+		"SMALL_SERIES_NKSXX",
+		"SMALL_SERIES_NKS",
 		"IVA_VCA",
 		"IVA_DVSA_NI"
 	],
@@ -29,7 +30,8 @@
 		"EU WVTA 23 on",
 		"QNIG",
 		"Prov.GB WVTA",
-		"Small series",
+		"Small series NKSXX",
+		"Small series NKS",
 		"IVA - VCA",
 		"IVA - DVSA/NI"
 	]

diff --git a/json-schemas/v3/tech-record/enums/approvalTypeHgvOrPsv.enum.json b/json-schemas/v3/tech-record/enums/approvalTypeHgvOrPsv.enum.json
@@ -9,7 +9,8 @@
 		"ECSSTA",
 		"GB_WVTA",
 		"PROV_GB_WVTA",
-		"SMALL_SERIES",
+		"SMALL_SERIES_NKSXX",
+		"SMALL_SERIES_NKS",
 		"IVA_VCA",
 		"IVA_DVSA_NI"
 	],
@@ -21,7 +22,8 @@
 		"ECSSTA",
 		"GB WVTA",
 		"Prov.GB WVTA",
-		"Small series",
+		"Small series NKSXX",
+		"Small series NKS",
 		"IVA - VCA",
 		"IVA - DVSA/NI"
 	]

diff --git a/json-schemas/v3/tech-record/get/hgv/complete/index.json b/json-schemas/v3/tech-record/get/hgv/complete/index.json
@@ -997,7 +997,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -1009,7 +1010,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/get/hgv/skeleton/index.json b/json-schemas/v3/tech-record/get/hgv/skeleton/index.json
@@ -1081,7 +1081,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -1093,7 +1094,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/get/hgv/testable/index.json b/json-schemas/v3/tech-record/get/hgv/testable/index.json
@@ -1069,7 +1069,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -1081,7 +1082,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/get/psv/complete/index.json b/json-schemas/v3/tech-record/get/psv/complete/index.json
@@ -236,7 +236,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -248,7 +249,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/get/psv/skeleton/index.json b/json-schemas/v3/tech-record/get/psv/skeleton/index.json
@@ -233,7 +233,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -245,7 +246,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/get/psv/testable/index.json b/json-schemas/v3/tech-record/get/psv/testable/index.json
@@ -215,7 +215,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -227,7 +228,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/get/trl/complete/index.json b/json-schemas/v3/tech-record/get/trl/complete/index.json
@@ -435,7 +435,8 @@
 						"EU_WVTA_23_ON",
 						"QNIG",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -451,7 +452,8 @@
 						"EU WVTA 23 on",
 						"QNIG",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/get/trl/skeleton/index.json b/json-schemas/v3/tech-record/get/trl/skeleton/index.json
@@ -415,7 +415,8 @@
 						"EU_WVTA_23_ON",
 						"QNIG",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -431,7 +432,8 @@
 						"EU WVTA 23 on",
 						"QNIG",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/get/trl/testable/index.json b/json-schemas/v3/tech-record/get/trl/testable/index.json
@@ -417,7 +417,8 @@
 						"EU_WVTA_23_ON",
 						"QNIG",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -433,7 +434,8 @@
 						"EU WVTA 23 on",
 						"QNIG",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/put/hgv/complete/index.json b/json-schemas/v3/tech-record/put/hgv/complete/index.json
@@ -964,7 +964,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -976,7 +977,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/put/hgv/skeleton/index.json b/json-schemas/v3/tech-record/put/hgv/skeleton/index.json
@@ -1040,7 +1040,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -1052,7 +1053,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/put/hgv/testable/index.json b/json-schemas/v3/tech-record/put/hgv/testable/index.json
@@ -1023,7 +1023,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -1035,7 +1036,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/put/psv/complete/index.json b/json-schemas/v3/tech-record/put/psv/complete/index.json
@@ -212,7 +212,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -224,7 +225,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/put/psv/skeleton/index.json b/json-schemas/v3/tech-record/put/psv/skeleton/index.json
@@ -227,7 +227,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -239,7 +240,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]

diff --git a/json-schemas/v3/tech-record/put/psv/testable/index.json b/json-schemas/v3/tech-record/put/psv/testable/index.json
@@ -201,7 +201,8 @@
 						"ECSSTA",
 						"GB_WVTA",
 						"PROV_GB_WVTA",
-						"SMALL_SERIES",
+						"SMALL_SERIES_NKSXX",
+						"SMALL_SERIES_NKS",
 						"IVA_VCA",
 						"IVA_DVSA_NI"
 					],
@@ -213,7 +214,8 @@
 						"ECSSTA",
 						"GB WVTA",
 						"Prov.GB WVTA",
-						"Small series",
+						"Small series NKSXX",
+						"Small series NKS",
 						"IVA - VCA",
 						"IVA - DVSA/NI"
 					]