Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch(*): removed null as acceptable value for complete and testable TRL #102

Merged
merged 4 commits into from
Aug 31, 2023
Merged

patch(*): removed null as acceptable value for complete and testable TRL #102

merged 4 commits into from
Aug 31, 2023

Conversation

Daniel-Searle
Copy link
Contributor

@Daniel-Searle Daniel-Searle commented Aug 31, 2023 •
edited by gjulien-bjss
Loading

Removed null as acceptable value for complete and testable TRL

One line description

CB2-XXXX

Changelog

  • Removed null as acceptable value for required fields in complete and testable TRL

@Daniel-Searle Daniel-Searle changed the title removed null as an acceptable value for TRL Removed null as acceptable value for complete and testable TRL Aug 31, 2023
gjulien-bjss
gjulien-bjss reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@gjulien-bjss gjulien-bjss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to edit the schemas under the json-definitions folder, hence the failing checks

@gjulien-bjss gjulien-bjss changed the title Removed null as acceptable value for complete and testable TRL path(*): removed null as acceptable value for complete and testable TRL Aug 31, 2023
@gjulien-bjss gjulien-bjss changed the title path(*): removed null as acceptable value for complete and testable TRL patch(*): removed null as acceptable value for complete and testable TRL Aug 31, 2023
@naathanbrown
Copy link
Contributor

Can you also add a line to the change log too please :)

@Daniel-Searle Daniel-Searle force-pushed the dan/remove-required-nulls branch from 015056c to e0de059 Compare August 31, 2023 12:57
@Daniel-Searle Daniel-Searle merged commit c7420c7 into develop Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naathanbrown naathanbrown naathanbrown approved these changes

@gjulien-bjss gjulien-bjss gjulien-bjss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel-Searle @naathanbrown @gjulien-bjss