Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: caching secrets #47

Merged
merged 1 commit into from
Jun 28, 2024
Merged

feat: caching secrets #47

merged 1 commit into from
Jun 28, 2024

Conversation

sr4850
Copy link
Contributor

@sr4850 sr4850 commented Jun 21, 2024

Refactored SecretsManager class to implement caching for secrets which should reduce the amount of calls made to AWS Secrets Manager

Related issue: JIRA_TICKET_NUMBER

Before submitting (or marking as "ready for review")

  • Does the pull request title follow the conventional commit specification?
  • Have you performed a self-review of the code
  • Have you have added tests that prove the fix or feature is effective and working
  • Did you make sure to update any documentation relating to this change?

@sr4850 sr4850 requested a review from kambales June 21, 2024 15:18
@dean-sogeti dean-sogeti self-assigned this Jun 28, 2024
@sr4850 sr4850 merged commit 4c4be98 into main Jun 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants