Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript module nodenext compatibility #182

Closed
wants to merge 3 commits into from

Conversation

rubencosta
Copy link

This PR fixes #181

Warning: I changed the exports from default export to named export which is a breaking change.
An alternative to a breaking change would be to keep both named and default exports but may be confusing for the package user to figure out which export to use.

@msobiecki
Copy link

msobiecki commented Apr 14, 2023

You should additionally update the readme. ;)

I reworked stackblitz (#142 (comment)) to test this solution:
https://stackblitz.com/edit/github-qvxva3?file=pages%2Findex.js

@rubencosta
Copy link
Author

Thanks @msobiecki, I have updated the readme.

@srmagura
Copy link
Collaborator

Fixed this in #187. Thanks for adding the exports to package.json — I used that in my PR.

@srmagura srmagura closed this Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript: Not compatible with config "moduleResolution": "nodenext"
3 participants