go-fuzz-build: added support for '-tags' #151
Conversation
go-fuzz-build/main.go
Outdated
| @@ -24,6 +24,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| flagTag = flag.String("tags", "", "a list of build tags to consider satisfied during the build.") | |||
There was a problem hiding this comment.
Proper way of doing it is using: https://godoc.org/golang.org/x/tools/go/buildutil#TagsFlag
There was a problem hiding this comment.
Thanks! I was not aware there was a tags flag
There was a problem hiding this comment.
Now that I'm looking at it I'm not sure I want to pull in a new package just for a flag. I'll let @dvyukov decide on whether he'd like this or not.
| if len(*flagTag) > 0 { | ||
| tags += " " + *flagTag | ||
| } | ||
| return tags |
There was a problem hiding this comment.
Joined tags should have form -tags="tagA tagB" try it out for yourself.
See also: golang/go#8772 (comment)
Thins get a bit tricky when you have multiple tags in play.
There was a problem hiding this comment.
Yes, indeed. This works though, it should be a space separated list of tags.
There was a problem hiding this comment.
If you mean that they need to be quoted, that's handled by the exec.Command
go-fuzz-build/main.go
Outdated
| @@ -24,6 +24,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| flagTag = flag.String("tags", "", "a list of build tags to consider satisfied during the build.") | |||
There was a problem hiding this comment.
s/a list/a space-separated list/ please
also no dot at the end, other flags don't use dots
|
Otherwise looks good. |
obscuren
force-pushed
the
tag-support
branch
from
ae8173d
to
65a9ad3
Compare
|
Done |
obscuren
force-pushed
the
tag-support
branch
from
65a9ad3
to
5397bca
Compare
|
Thanks! |
go-fuzz-build: added support for '-tags'
Please let me know if this is something that might be of interest and/or if you want me to expand further.