Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: disable modules via os.Setenv #241

Closed
wants to merge 3 commits into from
Closed

modules: disable modules via os.Setenv #241

wants to merge 3 commits into from

Conversation

thepudds
Copy link
Collaborator

@thepudds thepudds commented May 3, 2019

This passes travis when travis is updated to run tip, I think.

Note that changes were required to both go-fuzz-build and go-fuzz.

I started this prior to @josharian sending in #240. This PR can probably be abandoned in favor of #240, but sending in at least for contrast.

@thepudds thepudds changed the title modules: disable modules via os.SetEnv modules: disable modules via os.Setenv May 3, 2019
@josharian
Copy link
Collaborator

Thanks for sending this. I’m torn. This is short and succinct and easy to rip out later; on the other hand, this is a pretty big hammer. If the more targeted approach in #240 works, I guess I have a weak preference for it. I’m open to being convinced otherwise though. :)

@dvyukov
Copy link
Owner

dvyukov commented May 6, 2019

Uh, sorry, I saw @josharian PR before I saw that this exists. So what are we doing now?

@dvyukov dvyukov closed this May 6, 2019
@thepudds
Copy link
Collaborator Author

thepudds commented May 6, 2019

Hi @dvyukov, makes sense to close this one. Two solutions are better than none, but all we really need is one solution. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants