fix go-fuzz failing at Go tip, plus get testing passing again #323
Conversation
golang/go#44487 was likely causing tip to fail with a panic for the go-fuzz travis tests, perhaps due to the `// +build` in slides/crash.go and elsewhere. Also update the tested versions of Go.
…ther than go.mod for go-fuzz-dep
Also, temporarily use thepudds/go-fuzz-corpus fork.
…etting 'go 1.17' directive Workaround dvyukov#313. cmd/go should in theory pay attention to the version set in the 'go' directive when interpreting //go:build comments,
Avoid preserving '//go:build' comments in both trimComments and initialComments. Fixes dvyukov#313.
|
Currently running travis tests: https://travis-ci.org/github/dvyukov/go-fuzz/builds/773061221 |
.travis.yml
Outdated
| @@ -65,7 +65,7 @@ script: | |||
| - testscript -v testscripts/mod_vendor.txt | |||
|
|
|||
| # Prepare to test the png example from dvyukov/go-fuzz-corpus. | |||
| - go get -v -d github.com/dvyukov/go-fuzz-corpus/png | |||
| - git clone --depth=1 https://github.com/thepudds/go-fuzz-corpus $GOPATH/src/github.com/dvyukov/go-fuzz-corpus | |||
There was a problem hiding this comment.
Why do we clone the different repo (thepudds) into go-fuzz-corpus?
Do we need some fix in go-fuzz-corpus as well?
There was a problem hiding this comment.
Hi Dmitry 👋 thanks for the review!
Do we need some fix in go-fuzz-corpus as well?
The go-fuzz README likely needs to be updated regarding how to use go-fuzz-corpus (#317), and/or go-fuzz-corpus could become one or more modules, including to avoid #317 (comment). That was also the root cause of one of the ~5 reasons this testing was failing. I was taking an initial stab at a PR for go-fuzz-corpus, as well as using a go version directive in a go-fuzz-corpus go.mod as a potential workaround for the double '//go:build' issue (#313).
That said, I then switched gears to working around the go-fuzz-corpus module issues within travis (by creating a local test module in the travis script), including to keep this PR more self-contained.
In any event, I should switch the travis git clone back to dvyukov/go-fuzz-corpus, and that was my intent for this PR. Sorry for missing that.
This PR hopefully addresses a couple of go-fuzz issues, while also updating tests to handle changes in cmd/go. Travis has been failing on master for go-fuzz for ~5 different reasons for several months, but with these changes, travis is now passing again on my fork.
go-fuzz-build:
testscripts:
travis
// +buildin slides/crash.go and elsewhere.Fixes #313
Fixes #322