Default Scenarios #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisac
approved these changes
Jan 2, 2025
| @@ -30,7 +30,7 @@ | |||
| are cuboids, and the sides of the items must be packed parallel to the sides of bins. | |||
| """ | |||
|
|
|||
| RANDOM_SEED = 4 | |||
| RANDOM_SEED = 42 | |||
| "min": 1, | ||
| "max": 200, | ||
| "step": 1, | ||
| "value": 50, | ||
| "value": 8, |
There was a problem hiding this comment.
Is there a particular reason to go from 50x50x50 to 20x8x8 as default?
There was a problem hiding this comment.
Yeah it was requested by Catherine & the 50x50x50 was arbitrary
src/demo_enums.py
Outdated
Comment on lines
53
to
56
| ScenarioType.ONE_SMALL: "One Bin - Small", | ||
| ScenarioType.ONE_LARGE: "One Bin - Large", | ||
| ScenarioType.TWO_SMALL: "Two Bins - Small", | ||
| ScenarioType.TWO_LARGE: "Two Bins - Large", |
There was a problem hiding this comment.
To me, small and large makes it sound like it refers to the box size while it's actually the number of boxes. Maybe it could be named something else, e.g., many/few or small/large problem?
Updated: 79a30b7 Let me know if you want to do a final checkover or if it's good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #46
Added 4 default scenarios provided by @cpotts-dwave