Allow 100 character line length #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're starting to use python's typing module, 80 chars is becoming increasingly restrictive. This commit signals that dimod support 100 characters by adding it to the setup.cfg. Ideally we would like to add it to the pyproject.toml, but right now that's not supported. See PyCQA/pycodestyle#813
Codecov Report
@@ Coverage Diff @@
## main #835 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 69 69
Lines 5692 5692
=======================================
Hits 5056 5056
Misses 636 636 Continue to review full report at Codecov.
|
randomir
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're starting to use python's typing module, 80 chars is becoming increasingly restrictive.
This commit signals that dimod support 100 characters by adding it to the
setup.cfg. Ideally we would like to add it to thepyproject.toml, but right now that's not supported. See PyCQA/pycodestyle#813