Allow passing integers as tags to TaggedLogging::Formatter #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logstash and Elasticsearch accept integer values for keyword type fields, such as
tags
.LogStashLogger filters tags, not to pass
nil
s or empty strings as tags to Logstash.However, the empty string check does fail on everything that is not a string, and it does so in not a
very friendly manner:
This PR makes that check happen only on objects that respond to
#empty?
.