Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow .reset on MultiLogger #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpca
Copy link

@dpca dpca commented Feb 27, 2019

I'm using a MultiLogger and tried setting up the Phusion Passenger cleanup as specified:

::PhusionPassenger.on_event(:starting_worker_process) do |forked|
  Rails.logger.reset
end

but ran into the following error:

wrong number of arguments (given 1, expected 0) (ArgumentError)
  /usr/local/rvm/gems/ruby-2.5.3/gems/logstash-logger-0.26.1/lib/logstash-logger/logger.rb:23:in `reset'
  /usr/local/rvm/gems/ruby-2.5.3/gems/logstash-logger-0.26.1/lib/logstash-logger/multi_logger.rb:73:in `block in method_missing'
  /usr/local/rvm/gems/ruby-2.5.3/gems/logstash-logger-0.26.1/lib/logstash-logger/multi_logger.rb:71:in `each'
  /usr/local/rvm/gems/ruby-2.5.3/gems/logstash-logger-0.26.1/lib/logstash-logger/multi_logger.rb:71:in `method_missing'

I dug a bit and think this PR should fix it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant