Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build errors & formatting #1

Merged
merged 2 commits into from
May 30, 2024

Conversation

nate-double-u
Copy link

I think this sorts out the broken links in the main PR. I've also gone through and reformatted some tables and corrected some typos I saw.

I'm not sure exactly where all the links are supposed to go, so in some cases I've just removed them, a cue to find where they should go.

removing broken links

correcting typos

correcting link

formatting table

fixing links

Signed-off-by: Nate W <natew@cncf.io>
@@ -6,8 +6,8 @@ weight = 2
Reference information for the KEDA autoscaler.

- [Scaled Object specification](./scaledobject-spec)
- [ScaledJob specification](../concepts/scaling-jobs/#scaledjob-spec)
- [ScaledJob specification](./scaledjob-spec.md)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct, but it should be double checked

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's correct.

@nate-double-u nate-double-u changed the title formatting tables Fixing build errors & formatting May 29, 2024
Copy link
Owner

@dwelsch-esi dwelsch-esi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments and suggestions regarding removed links. Otherwise LGTM.

@@ -6,8 +6,8 @@ weight = 2
Reference information for the KEDA autoscaler.

- [Scaled Object specification](./scaledobject-spec)
- [ScaledJob specification](../concepts/scaling-jobs/#scaledjob-spec)
- [ScaledJob specification](./scaledjob-spec.md)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's correct.

Signed-off-by: Dave Welsch <116022979+dwelsch-esi@users.noreply.github.com>
@dwelsch-esi dwelsch-esi merged commit 6ea6ed8 into dwelsch-esi:doc-issues May 30, 2024
@nate-double-u nate-double-u deleted the doc-issues branch May 30, 2024 22:23
dwelsch-esi added a commit that referenced this pull request May 30, 2024
* formatting tables

removing broken links

correcting typos

correcting link

formatting table

fixing links

Signed-off-by: Nate W <natew@cncf.io>

* Update content/docs/2.15/operate/_index.md

Signed-off-by: Dave Welsch <116022979+dwelsch-esi@users.noreply.github.com>

---------

Signed-off-by: Nate W <natew@cncf.io>
Signed-off-by: Dave Welsch <116022979+dwelsch-esi@users.noreply.github.com>
Co-authored-by: Dave Welsch <116022979+dwelsch-esi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants