Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Barbuddy Bug #652

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Fix Barbuddy Bug #652

merged 4 commits into from
Feb 13, 2025

Conversation

ilgazer
Copy link
Contributor

@ilgazer ilgazer commented Jan 12, 2025

Fixes #595, the correct barbuddies are now loaded when the language is changed from the navbar.

@ilgazer ilgazer changed the title test Fix Barbuddy Bug Jan 12, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 12, 2025

Deploying outsite-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1cc22b4
Status: ✅  Deploy successful!
Preview URL: https://4c3d4f11.dwhdelft-nl.pages.dev
Branch Preview URL: https://fix-barbuddy-bug.dwhdelft-nl.pages.dev

View logs

@ilgazer ilgazer changed the title Fix Barbuddy Bug Fix Barbuddy Bug - Draft Jan 12, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 12, 2025

Deploying dwhdelft-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1cc22b4
Status: ✅  Deploy successful!
Preview URL: https://d8466d8b.dwhdelft-nl-u1a.pages.dev
Branch Preview URL: https://fix-barbuddy-bug.dwhdelft-nl-u1a.pages.dev

View logs

@ilgazer ilgazer changed the title Fix Barbuddy Bug - Draft Fix Barbuddy Bug Jan 12, 2025
Copy link
Member

@thomcsmits thomcsmits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@casperboone casperboone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the useful workaround, this resolves the issue indeed!

Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying lg33-nl with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1cc22b4
Status: ✅  Deploy successful!
Preview URL: https://4c4b09de.lg33-nl.pages.dev
Branch Preview URL: https://fix-barbuddy-bug.lg33-nl.pages.dev

View logs

@ilgazer ilgazer requested a review from casperboone February 5, 2025 22:45
@casperboone
Copy link
Member

casperboone commented Feb 13, 2025

Awesome, thx!

@casperboone casperboone merged commit ffa87e2 into main Feb 13, 2025
4 checks passed
@casperboone casperboone deleted the fix-barbuddy-bug branch February 13, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Barbuddies missing descriptions but still showing in English
3 participants