Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Str::squish() signature #6

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Fix Str::squish() signature #6

merged 1 commit into from
Apr 8, 2022

Conversation

danharrin
Copy link
Contributor

Fixes #5.

@danharrin danharrin mentioned this pull request Apr 8, 2022
Closed
@dwightwatson
Copy link
Owner

Could we just remove the entire method? It's basically the same implementation so it should work just as expected I think.

@dwightwatson
Copy link
Owner

Actually I'll just merge this for now so you can have it work with dev-master. Won't be able to tag a release straight away as I'm not at a computer.

@dwightwatson dwightwatson merged commit 7730825 into dwightwatson:master Apr 8, 2022
@dwightwatson
Copy link
Owner

Appreciate your help finding this and sorting it out!

@danharrin
Copy link
Contributor Author

Could we just remove the entire method? It's basically the same implementation so it should work just as expected I think.

I didn't do that because we need to maintain L8 compatibility, right?

@dwightwatson
Copy link
Owner

Good point. Maybe I'll prep a release to drop Laravel 8 support just to avoid any inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Str::squish(string $string): string must be compatible
2 participants
@danharrin @dwightwatson