stack level too deep when mount on a column named "file"

[plentz]

If you have you uploader mounted on a column named file, like this:

class Attachment < ActiveRecord::Base
  attr_accessible :name, :file, :size, :attachable_id, :attachable_type, :content_type
  mount_uploader :file, AttachmentUploader
  ... 
end

You will see a SystemStackError (stack level too deep) when trying to use create, like this:

Attachment.new(params[:attachment])

It's the same problem related in #10 and #18. I don't know why they closed the other issues, when it's clearly a problem in the gem(in my opinion), since it works with regular carrierwave(and it's pretty hard for a user to figure it out).

[plentz]

@dwilkie I think my solution is pretty straightforward - and the tests are green. Please merge it if you think it's ok or comment what you think I can change to meet with your requirements. Thanks in advance

[dwilkie]

@plentz let's just wait for @nddeluca to take a look, he's actively maintaining this gem.

[plentz]

@nddeluca it's up to you :)

[nddeluca]

@plentz Thanks for solving this! I'm in the process of playing around with this in a rails app. Also, is it possible to add a test so we don't accidentally break this again later?

[plentz]

@nddeluca I will try to add a test for this and I ping you when it's done.

[nddeluca]

Awesome, thanks!

[plentz]

@nddeluca hey! Just a quick update on this. I just found that the order of things change the behavior! I think we can find a better solution to this problem, since this fails:

  attr_accessible :file
  mount_uploader :file, AttachmentUploader

But this works:

  mount_uploader :file, AttachmentUploader
  attr_accessible :file

I will look further.

[mois3x]

@plentz why this hasn't been merged? I used this gem and i get that same bug :S what's the problem then?

[plentz]

@mois3x I didn't created a test to ensure that we don't break this again. If you want to write a test to it, you can make a pull request to my repository https://github.com/plentz/carrierwave_direct and then we merge this alltogheter.

[mois3x]

@plents , could update your repo? i made the test in the updated fork of my repo. anyway i'll make you a pull request and u tellme if i have to do something more again

[sunny]

👍 The patch fixes the issue here as well.

[fabn]

Applied in #188.