Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with backdrop staying in fast state change #223

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hackeo1
Copy link

@hackeo1 hackeo1 commented Sep 20, 2017

No description provided.

@hackeo1
Copy link
Author

hackeo1 commented Sep 20, 2017

I had a problem with the state change in one specific change. I hope this can help other people. If any change is required to make the pull request just let me know.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 84.884% when pulling 42c591d on hackeo1:master into 5f65f6e on dwmkerr:master.

@dwmkerr
Copy link
Owner

dwmkerr commented Sep 25, 2017

This looks good - the only suggestion I would make is a quick comment above the line explaining why we have a delay

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 84.884% when pulling 86cf9c9 on hackeo1:master into 5f65f6e on dwmkerr:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 84.884% when pulling 86cf9c9 on hackeo1:master into 5f65f6e on dwmkerr:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants