You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change resolves issues with Node.js 17 and newer and fixes#81.
Node.js 17 and newer do not order ip addresses when resolving them, this means that a server that is listening on localhost previously always listened on 127.0.0.1 with the Node.js 17+ it might also be listening on ::1. To support this new behavior, wait-port now tries to connect to IPv4 first and then to IPv6 when the supplied hostname is not an IP.
I change the return value to include the ipVersion and because of this this is a breaking change.
BREAKING CHANGE: Returns now an object instead of an boolean. The object
contains the property open: boolean and if open is true it will
also contain ipVersion which will be 4 or 6 dependening on which IP
version the open port was found on.
Hi @danez would you mind updating from main? I've fixed up the build pipeline so that it builds with Node 12, 14, 16, 18, I think the PR you've made might fail 12/14 but not 16 onwards, this should confirm. It might be that the code that handles IP v4/6 needs to be conditional dependent on the node platform
BREAKING CHANGE: Returns now an object instead of an boolean. The object
contains the property `open: boolean` and if `open` is `true` it will
also contain `ipVersion` which will be `4` or `6` dependening on which IP
version the open port was found on.
Sorry for the confusion, I checked the tests and noticed I forgot to update them. Because this PR changes the return value to an object instead of a boolean.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change resolves issues with Node.js 17 and newer and fixes #81.
Node.js 17 and newer do not order ip addresses when resolving them, this means that a server that is listening on
localhostpreviously always listened on127.0.0.1with the Node.js 17+ it might also be listening on::1. To support this new behavior, wait-port now tries to connect to IPv4 first and then to IPv6 when the supplied hostname is not an IP.I change the return value to include the ipVersion and because of this this is a breaking change.
BREAKING CHANGE: Returns now an object instead of an boolean. The object
contains the property
open: booleanand ifopenistrueit willalso contain
ipVersionwhich will be4or6dependening on which IPversion the open port was found on.