CVE-2007-4559 Patch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikolaj-staworzynski-red
pushed a commit
to mikolaj-staworzynski-red/onemw-depot-tools
that referenced
this pull request
Jan 17, 2025
When true and got_revision_cp is present, output commit ref and position are set from got_revision_cp. Default value is true.
For Chrome builds that build from tags we will set parse_commit_position to false to show tags instead of branches on Buildbucket UI, e.g. refs/tags/132.0.6824.0 instead of refs/branch-heads/6824@{dwrobel#1}.
Bug: 366409421
Change-Id: I77d01615edb6b791445a06469f80c673c97ad8d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6000539
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Alex Kravchuk <alexanderkr@google.com>
mikolaj-staworzynski-red
pushed a commit
to mikolaj-staworzynski-red/onemw-depot-tools
that referenced
this pull request
Jan 17, 2025
…eckout." This reverts commit 66b3972. Reason for revert: This won't work because chromium_checkout relies on the position being set in the output commit in order to set information for RDB. We'll have to come up with a different solution. Original change's description: > Add parse_commit_position parameter to BotUpdateApi.ensure_checkout. > > When true and got_revision_cp is present, output commit ref and position are set from got_revision_cp. Default value is true. > > For Chrome builds that build from tags we will set parse_commit_position to false to show tags instead of branches on Buildbucket UI, e.g. refs/tags/132.0.6824.0 instead of refs/branch-heads/6824@{dwrobel#1}. > > Bug: 366409421 > Change-Id: I77d01615edb6b791445a06469f80c673c97ad8d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6000539 > Reviewed-by: Garrett Beaty <gbeaty@google.com> > Reviewed-by: Scott Lee <ddoman@chromium.org> > Commit-Queue: Alex Kravchuk <alexanderkr@google.com> Bug: 366409421 Change-Id: I21a5fc6e011a64fffd1d2ef0689d5a3f3843482c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6037603 Reviewed-by: Garrett Beaty <gbeaty@google.com> Commit-Queue: Alex Kravchuk <alexanderkr@google.com> Reviewed-by: Scott Lee <ddoman@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching CVE-2007-4559
Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.
If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.