Adds contributing.md #253
Merged
Adds contributing.md #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iteles
added
the
awaiting-review
iteles
removed
the
awaiting-review
|
|
iteles
added
the
in-progress
|
|
|
@iteles on the basis that the node tests are no longer relevant, we can just merge this PR. |
|
@nelsonic Seeing as the code in this repo will be entirely replaced and this PR is an addition for an |
iteles
added
awaiting-review
nelsonic
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
@iteles as discussed, the Travis-CI build for this project is currently out-of-date.
It will be replaced by the Phoenix version dwyl/mvp#24 once it's ready.
On that basis I'm happy to merge the PR as the contributing.md adds value. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in the information from our conversations on labels and that have been summarised in the comments on #239.
These largely are around the inclusion of the
needs-criteriaandneeds-uilabels and will be rounded off with the next PR which is the wider workflow for #238.