Updates contributing.md #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iteles
added
the
awaiting-review
iteles
commented
Dec 13, 2019
| [Github Project](https://github.com/dwyl/app/projects) where ***issues are kept | ||
| in prioritised order***. | ||
|
|
||
| > The `To Do` column of the kanban board should only contain issues that are |
There was a problem hiding this comment.
There is an outstanding task with me here to go through the current To Do column and ensure this is enforced
SimonLab
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the updates to our workflow we have agreed upon in #238 and already tweaked a bit.
I wanted to make sure I documented any departures from our main 'contributing' workflow here so that we can evolve it and pull everything together in the coming months.
Please take a readthrough and let me know if anything needs clarification or addition/amendment ✨
Further note: I'm opening the PR in this repo because my original
mdfile was also merged here but I can just create a PR for this in the mvp app repo if that's better?Travis fails here just as it did last time which is irrelevant given all of the code is being replaced.