Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API Keys UI? #107

Closed
4 tasks done
nelsonic opened this issue Sep 10, 2020 · 1 comment
Closed
4 tasks done

Remove API Keys UI? #107

nelsonic opened this issue Sep 10, 2020 · 1 comment
Assignees
@nelsonic
Labels
chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

nelsonic commented Sep 10, 2020 •
edited
Loading

Given that we now have the concept of "Apps" #95 which will be more familiar to some people, I propose that we:

  • Remove the UI for creating API keys because it's no longer relevant.

    I have removed the name, description and url fields of the apikeys schema in favour of storing this info in apps so it's no longer a valid use-case to have an apikey without an app

  • Create a "Reset API Key" button in the App "Show" View e.g. /apps/1 to allow people to easily reset their key (but keep their App active) if they fear that it's been compromised.
  • Move the AuthWeb.ApikeyController.make_apikey/2 function from the controller to the schema file where it is more appropriate.
  • Remove all tests that manually create apikeys records via the ApikeyController. (UI tests)
@nelsonic nelsonic added chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Sep 10, 2020
@nelsonic
Copy link
Member Author

Reset API Key UI:
auth-app-reset-api-key

@nelsonic nelsonic added the T1h Time Estimate 1 Hour label Sep 10, 2020
@nelsonic nelsonic self-assigned this Sep 10, 2020
@nelsonic nelsonic mentioned this issue Sep 10, 2020
Merged
13 tasks
nelsonic added a commit that referenced this issue Sep 10, 2020
@nelsonic
comment out UI tests in test/auth_web/controllers/apikey_controller_t…
c17bcbb 
…est.exs #107
nelsonic added a commit that referenced this issue Sep 10, 2020
@nelsonic
delete lib/auth_web/templates/apikey to avoid warnings #107
bc136ce
nelsonic added a commit that referenced this issue Sep 10, 2020
@nelsonic
remove lib/auth_web/views/apikey_view.ex as no longer needed #107
13cca0e
nelsonic added a commit that referenced this issue Sep 10, 2020
@nelsonic
all tests passing again after removing API Key UI #107
259149d
nelsonic added a commit that referenced this issue Sep 10, 2020
@nelsonic
🔪 DELETE apikey_controller.ex and apikey_controller_test.exs #107
b0ff09f
nelsonic added a commit that referenced this issue Sep 10, 2020
@nelsonic
all tests passing again after removing API Key UI #107
f59cdf9
nelsonic added a commit that referenced this issue Sep 10, 2020
@nelsonic
check for API Keys that are "deleted" in get_client_secret/2 #107 + #106
3c4e5a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
chore a tedious but necessary task often paying technical debt discuss Share your constructive thoughts on how to make progress with this issue T1h Time Estimate 1 Hour technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic