Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit API Key Record to Update the Description, Name & URL #58

Closed
2 tasks done
nelsonic opened this issue Apr 29, 2020 · 3 comments
Closed
2 tasks done

Edit API Key Record to Update the Description, Name & URL #58

nelsonic opened this issue Apr 29, 2020 · 3 comments
Assignees
@nelsonic
Labels
enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person starter A beginner-friendly issue that is a good starting point for a new person T1h Time Estimate 1 Hour T25m Time Estimate 25 Minutes

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 29, 2020 •
edited
Loading

At present attempting to edit shows an error:
image

We can fix this easily.

Todo

  • Enable Edit Form
  • Show 404 if a person attempts to edit an API Key they don't own.
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes starter A beginner-friendly issue that is a good starting point for a new person T1h Time Estimate 1 Hour labels Apr 29, 2020
@nelsonic nelsonic self-assigned this Apr 29, 2020
@nelsonic nelsonic added the in-progress An issue or pull request that is being worked on by the assigned person label Apr 29, 2020
nelsonic added a commit that referenced this issue Apr 29, 2020
@nelsonic
add tests for Edit API Key data #58
2a4bcdc
nelsonic added a commit that referenced this issue Apr 29, 2020
@nelsonic
add Edit API Key implementation fixes #58
9969305
@nelsonic nelsonic mentioned this issue Apr 29, 2020
Merged
12 tasks
@nelsonic
Copy link
Member Author

Created:
image

Edited:
image

Updated:
auth-api-key-edit

@nelsonic
Copy link
Member Author

image

image

Attempt to edit a key I don't own:
image

nelsonic added a commit that referenced this issue Apr 30, 2020
@nelsonic
create tests for update/2 for #58
49a8da2
nelsonic added a commit that referenced this issue Apr 30, 2020
@nelsonic
enable update_key/2 function #58
caeb731
nelsonic added a commit that referenced this issue Apr 30, 2020
@nelsonic
update/2 for #58
6cf8c37
nelsonic added a commit that referenced this issue Apr 30, 2020
@nelsonic
add test for checking api key ownership in update/2 for #58
21fae61
nelsonic added a commit that referenced this issue Apr 30, 2020
@nelsonic
modify update/2 (update api key) to check for ownership #58
d4cc4d8
@nelsonic
Copy link
Member Author

Heroku Workflow:
image

No API Keys:
image

New API Key:
image

image

Created:
image

Edit:
image

Updated:
image

Attempt to edit a key I don't own: 404
image

Done!

Now to tidy up the UX! #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person starter A beginner-friendly issue that is a good starting point for a new person T1h Time Estimate 1 Hour T25m Time Estimate 25 Minutes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic