Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode cid #17

Closed
wants to merge 1 commit into from
Closed

decode cid #17

wants to merge 1 commit into from

Conversation

SimonLab
Copy link
Member

ref #13 #15

  • Check for v0 format, ie start with Qm and length is 46 (not sure why about the length)

@SimonLab SimonLab self-assigned this Jan 22, 2019
@nelsonic
Copy link
Member

@SimonLab we don't need to decode v0.
Apologies for not making that clear in #11
We only need to do what is listed in #11.
We need to generate a few test CIDs using the JS version
and then test those in our Elixir version, that's it.
No decoding required at this stage.

If you feel this is "almost done" that's fine we can merge it.
But if you feel there is still 4+ Hours of work to do, then let's "shelve" it
and focus on creating V1 CIDs compatible with JS.

@SimonLab
Copy link
Member Author

closing as the decode function is not necessary. The PR #21 is also more up to date

@SimonLab SimonLab closed this Jan 30, 2019
@SimonLab SimonLab deleted the is-cidv0 branch January 30, 2019 11:18
@SimonLab SimonLab removed their assignment Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants